Giter Club home page Giter Club logo

Comments (5)

davidben avatar davidben commented on August 11, 2024

Java does provide an SSLSessionContext.getSession API which gets in the way of this, but since the returned SSLSessions aren't useful for anything, always returning null seems a sound choice. At a glance, it appears Netty does this and always makes SSLSocket.getSession and SSLSocket.getHandshakeSession return child objects of the socket as described here.

from conscrypt.

kruton avatar kruton commented on August 11, 2024

Comments on this unsubmitted CL are relevant.

from conscrypt.

nmittler avatar nmittler commented on August 11, 2024

We should import some of the android tests to verify these changes.

https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/

then it's stuff like javax/net/ssl/SSLSocketTest.java

Subdirectories for many of the tests:
https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/java/security/
https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/javax/net/ssl/
https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/javax/crypto/

from conscrypt.

nmittler avatar nmittler commented on August 11, 2024

FYI, Kenny's work on this was captured in these 2 CLs (the latter is to be applied on the former):

https://android-review.googlesource.com/#/c/309613/
https://android-review.googlesource.com/#/c/312011/

from conscrypt.

nmittler avatar nmittler commented on August 11, 2024

FYI, I've merged the two CLs into a single commit on GitHub:

nmittler@6362f73

from conscrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.