SSLException: encrypted packet oversized about conscrypt HOT 9 CLOSED

@amosyuen Has this issue been fixed for you?

We're using the Android Async library (upon which Ion is based) and many of our users are experiencing this crash on some of the newest versions of Google Play Services (I've only seen it on the beta versions myself).

Pardon my ignorance, but after a fair amount of searching it's not obvious to me if this is fixed and soon to be released as an update to the beta version or if this will remain as is and we'll need to bother the Android Async guys for an update (or do something ourselves...). If someone could please enlighten me and perhaps give a rough time estimation, that would be much appreciated!

from conscrypt.

@deanrobertcook unfortunately last I checked a couple of months ago, it seems the problem wasn't fixed. I'm not entirely sure if it's an Ion not using the new version or a continued conscrypt problem, but in the end our team decided to use a different library than Ion.

from conscrypt.

Yes, that seems like it should be checking against the result of SSLUtils.getEncryptedPacketLength(srcs, srcsOffset) and not len.

from conscrypt.

@nmittler could you take a look at this?

from conscrypt.

@kruton yup will look today.

from conscrypt.

@kruton I actually think what we want to do here is to only process a single packet, regardless of how much we receive in the source buffers.

So basically we only want to process SSLUtils.getEncryptedPacketLength(srcs, srcsOffset) bytes at a time.

from conscrypt.

@amosyuen thanks! It's looking more like we might have to do the same. Which library are you using now? If you don't mind me asking.

from conscrypt.

We went with https://square.github.io/retrofit/

from conscrypt.

There was a further fix in #189.

from conscrypt.