Consider making NativeConstants public about conscrypt HOT 3 CLOSED

Please do not do this. Expose exactly and only the APIs you intend to expose. Looking at that file, most of those constants would be unacceptable to expose outside the library.

from conscrypt.

@davidben SGTM. We already expose one constant value (albeit associated with a particular engine instance) here. It probably makes sense to follow suit with any specific constants that we wish to expose. What I'm currently thinking could be useful would be:

• SSL3_RT_HEADER_LENGTH
• SSL3_RT_MAX_PACKET_SIZE
• SSL3_RT_MAX_PLAIN_LENGTH

Does that seem reasonable?

from conscrypt.

@kruton and @davidben, I just noticed that NativeConstants and all of its constants are already public. The class is marked with @hide in the javadoc, but that seems rather insufficient to address @davidben's concerns. I suspect we should do something here.

from conscrypt.