Comments (2)
Hi Xiang, thanks for your interest in the release and for taking a careful look at the code!
You are absolutely correct that if we were applying a minimum image convention, that code would be wrong. However, these lines are only there because as walkers move far from the origin, they move outside the region of physical space where we are actually taking the Ewald sum. We only need to move the walkers 'close' (by some definition related to the truncation length) to the origin, and so an electron occasionally being one image over from the minimum image does not cause a problem.
To lay your mind at ease: I have calculated the potential of two electrons separated as you suggested by a distance of 0.6 units with/without your suggested edit (here I am using NumPy only, no JAX, and double precision):
without edit: -2.75527802498627
with edit: -2.7552780249862696
(simple cubic lattice, lattice constant 1 bohr, no atomic potential, include_heg_background=True
)
I'm not sure this -needs- to be fixed, however, it cannot hurt and might save someone anxiety about the same problem in future. I would like to lay any readers' minds to rest thought that this does not cause the code to give 'wrong answers' as far as I can tell.
from ferminet.
Dear Gcassella,
Thanks for the quick response. I agree that the difference is quite small and won't affect the correctness of present work. I just worry that this difference might lead to some problems at extremely special cases and that's why I raise the issue.
from ferminet.
Related Issues (20)
- Jax install - issue with correct version number HOT 1
- AttributeError: module 'jax.core' has no attribute 'extract_call_jaxpr' HOT 1
- Jax error running on A100 GPU (everything is okay on CPU) HOT 2
- unable to setup HOT 1
- The proper way to cite FermiNet repo HOT 1
- Ground State Energies HOT 2
- nan when training with 'adam' HOT 1
- About configs HOT 3
- Question About load Checkpoint HOT 1
- Evaluating logprob using batch_network in train HOT 1
- Issue on running pytest HOT 5
- Extension of PBC code to 1D HOT 7
- Something went wrong in RepeatedDenseBlock.update_curvature_matrix_estimate HOT 2
- Different results obtained from the paper for ch3nh2 HOT 2
- kfac_jax error when running H2 example script HOT 2
- Upstream breaking change in `kfac-jax`
- KeyError raised after burn-in MCMC steps HOT 1
- Logdet Bug Similar to e9f8c64 HOT 1
- Natural Excited States to nan HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ferminet.