False assumption: IPs appear in a single position about cli HOT 3 CLOSED

Likewise getHostPosition getHostPosition and getHostnamePosition need plural versions

from cli.

good find!

from cli.

I notice that in places in the code it uses this and then loops until no instances are found, and in other places it might not do this.

Instead, if it fetched all positions, sorted them from smallest to largest, then worked backwards from the end of the file to the start, we can achieve the same result using these functions. I did start on adding the functions which seemed easy enough, but didn't look into using them, golang isn't super familiar to me. Something like this is what I was thinking:

func (h Hosts) getIpPositions(ip string) []int {
	positions := new [...]int
	for i := range h.Lines {
		line := h.Lines[i]
		if !line.IsComment() && line.Raw != "" && line.IP == ip {
			append(positions, i)
		}
	}

	return positions
}

from cli.