Giter Club home page Giter Club logo

Comments (7)

nesangcode avatar nesangcode commented on June 16, 2024

Can I assigned to this issue?

from athens.

matt0x6F avatar matt0x6F commented on June 16, 2024

Can I assigned to this issue?

Yeap! Go for it.

from athens.

nesangcode avatar nesangcode commented on June 16, 2024

In s3_test.go, it'll skip getStorage test if ATHENS_MINIO_ENDPOINT not set up. How can I test getStorage() without set ATHENS_MINIO_ENDPOINT?

func getStorage(t testing.TB) *Storage {
	url := os.Getenv("ATHENS_MINIO_ENDPOINT")
	if url == "" {
		t.SkipNow()
	}
	...
}

from athens.

matt0x6F avatar matt0x6F commented on June 16, 2024

@k124k3n try the docker based e2e tests. There's a target in the Makefile that correlates to this.

from athens.

nesangcode avatar nesangcode commented on June 16, 2024

Seem's like AWS SDK v2 require protocol:// in Endpoint.

When I set export ATHENS_MINIO_ENDPOINT="127.0.0.1:9001", it fails on s3_test.go:

s3_test.go:104: operation error S3: CreateBucket, resolve auth scheme: resolve endpoint: endpoint rule error, Custom endpoint `127.0.0.1:9001` was not a valid URI

When I set export ATHENS_MINIO_ENDPOINT="http://127.0.0.1:9001", it fails on minio_test.go:

--- FAIL: TestBackend (0.00s)
    minio_test.go:107: address http://127.0.0.1:9001: too many colons in address
--- FAIL: TestNewStorageExists (0.00s)
    minio_test.go:39: TestNewStorageExists failed for bucketname:  testbucket, error: address http://127.0.0.1:9001: too many colons in address

Should we add protocol:// in aws.Config.Endpoint?

from athens.

matt0x6F avatar matt0x6F commented on June 16, 2024

@k124k3n since Minio is the only one that expects there not to be a protocol in the address could we make part of the function trim prefixes for http:// and https://?

from athens.

nesangcode avatar nesangcode commented on June 16, 2024

Sure, also, we should update Athens S3 documentation to refer into AWS SDK v2 docs.

from athens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.