frontend's method commit_message not setting author of commit properly about gollum HOT 5 CLOSED

Hello everybody.
I have a fix for this bug in my fork. You can find it here ; http://github.com/dblugeon/gollum/tree/correct_commit_message_method .

Warning, this fix doesn't correct an existing repository. You can try correct the repository with the git rebase command.

from gollum.

Thanks for the patch. I don't think I want the Wiki object calling git directly though. This approach is only valid for single-user gollum servers. I handle this in a completely different way on the GitHub app by taking the name/email from your User object.

from gollum.

I have created the Gollum::Wiki.commit_message method to make easier unit test for this.

Is it a good way if I create a "gitHelper" to store this function? And app.rb to call this?

from gollum.

Ok, let me know how this works out.

from gollum.

I try this, and it's ok for me.

Thank you.

from gollum.