Comments (2)
I understand this is probably a challenge because you don't want to be returning the raw source to the end user, and if you cut out a line it may not parse properly if you want to attempt to convert it to html. It's a challenge but imo it's one that'll need to be overcome.
The current approach (#343) will return raw source to the end user and HTML escape it (one line of context). Given that the user is searching through markup source documents (and possibly searching for an expression containing markup), I think it would be unnecessary and unexpected to render the search context.
from gollum-lib.
Resolved in #343
from gollum-lib.
Related Issues (20)
- sanitize lib needs update (CVE-2018-3740) HOT 4
- Recent versions of sanitize break jruby HOT 1
- Depends on an old version of sanitize HOT 14
- Make file search case insensitive HOT 1
- 5.x: TOC doesn't show up in subpages HOT 2
- Set commit date on committing changes HOT 12
- Gollum should register ".adoc" as a valid file extension for AsciiDoc
- Series macro can't be used in subpages
- pandoc-citeproc no longer supported HOT 2
- Improve Navigation or TOC.
- Make dependency on twitter optional HOT 1
- markups @master still referring to python2 for rst support HOT 2
- Possible to append to default filter chain? HOT 5
- More efficient sanitization
- Customization (like sorting and filtering) of the navigation or TOC macros? HOT 1
- Default CommonMarker options?
- Advanced search HOT 5
- Add page categorization (or concept tagging) feature HOT 8
- Macro filter turned boolean arguments into string HOT 2
- Rethink logic for Macro sanitization HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gollum-lib.