Korean translation 행운을 빕니다 about nodebestpractices HOT 22 CLOSED

@uronly14me 안녕하세요, 제가 진행중 여러 일이 겹쳐 진행을 못하고 있었습니다. 같이 진행해도 좋을것 같습니다.

from nodebestpractices.

@uronly14me @hinco114 hmmm, could you translate that for us? 😉

from nodebestpractices.

@i0natan I tried to merge Master branch to korean-translate branch for update changes, but this operation cause conflict.
I think you renamed that file name and committed.
By the way, @XoDNr dose not respond, how do I to contribute? Just PR to this branch?
If dose, one solution is I manually merge this conflict.
And the other way is make new branch from current Master branch.

from nodebestpractices.

@i0natan Hello, I want to translate it to Korean too.

from nodebestpractices.

Hello, I want to translate it to Korean.

from nodebestpractices.

Welcome, @cisco0808! You can create a fork, translate pages that remain untranslated, and create a pull request like this one (#665). I currently have a pending PR (#671) that translates sections 1.4-2.1, so you will want to avoid translating those files to avoid duplicated efforts.

from nodebestpractices.

Thank you so much! i'll do my best! Good luck to all you guys, 행운을 빕니다!

from nodebestpractices.

Our pleasure to have you here, LMK whether you need anything to push forward.

I suggest pushing a short version (e.g. one bullet), solicit feedback whether all is done right and then proceed

from nodebestpractices.

@XoDNr no rush, just checking whether everything is clear and if I assist in anyway?

from nodebestpractices.

@i0natan It looks like doesn't progress... Can I participate in this project?

from nodebestpractices.

@hinco114 our pleasure to have you hear, I suggest we first ping @XoDNr and ask for his advice?

from nodebestpractices.

@XoDNr 저도 같이 작업을 하고 싶은데 어떻게 참여 할 수 있을까요?

from nodebestpractices.

@hinco114 Yes, the way to go is PRing into the Korean branch, not master. Then once it's 100% ready PR the branch into master. Did you finish the entire translation work and want to merge into the master? on which files/branch do are you facing conflicts? I'll be glad to halp in resolving the conflicts

from nodebestpractices.

@i0natan Not finished yet, I'm working on it as I have time, but I think it'll take a long time.
I merged master branch into korean-translate branch, and README.korean.md file conflicts with README.chinese.md file.
You can see that conflict when trying to merge or rebase master branch on korean-translate branch.

from nodebestpractices.

@hinco114 thanks for the update, I'll take a look at the conflict issue soon and share my thoughts. Does it block you now?

from nodebestpractices.

Not really, I manually see the difference. But I will do the work faster if that problem is solved.

from nodebestpractices.

@hinco114 Fixed the merging issue, kindly pull latest korean-translation. Does it work for you now?

from nodebestpractices.

@i0natan I have been busy so reply late. It worked well. I'll PR for the results of my work so far soon. It's not completed version, only translated main important parts.

from nodebestpractices.

@hinco114 Sounds great, let's push it one bite at a time. Maybe as a first version we can translate the home page only and leave the inner pages in English?

from nodebestpractices.

@hinco114 안녕하세요! #229 에대해 리뷰를 요청합니다.

from nodebestpractices.

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

from nodebestpractices.

Not sure who's in charge of reviewing the PRs for Korean translations anymore.
@goldbergyoni @hinco114 @uronly14me Mind reviewing #651?

from nodebestpractices.