Completion including method local vars which are out of scope about pi HOT 4 CLOSED

I found the source of pi issue #5 but I’m undecided about the best way to fix. The problem is the recursion in the code below. I am leery about adding a bool recurse argument as the method as it would be necessary in a chain of methods. I lean towards a another set of methods that don’t recurse. It would mean some method name changes to make it clear which set did the recursion.

// FindNamePrefix looks for given symbol name prefix within this map
// and any children on the map.
// adds to given matches map (which can be nil), for more efficient recursive use
func (sm *SymMap) FindNamePrefix(seed string, matches *SymMap) {
noCase := true
if complete.HasUpperCase(seed) {
noCase = false
}
for _, sy := range *sm {
nm := sy.Name
if noCase {
nm = strings.ToLower(nm)
}
if strings.HasPrefix(nm, seed) {
if *matches == nil {
*matches = make(SymMap)
}
(*matches)[sy.Name] = sy
}
}
for _, ss := range *sm {
ss.Children.FindNamePrefix(seed, matches)
}
}

from pi.

Yep go ahead and add a new set of methods. FindNamePrefixRecursive vs. FindNamePrefix?

from pi.

Yes, that naming is very clear!

from pi.

Done

from pi.