Giter Club home page Giter Club logo

Comments (11)

gokcehan avatar gokcehan commented on July 17, 2024

This was in the example lfrc @KenjiTakahashi but I removed it the other day when I realized it wasn't working :) Traditionally people make use of key delays to make it possible to have such mappings. I haven't added this yet since synchronization might be necessary for ui and the rest.

Unmapping is on the agenda.

from lf.

KenjiTakahashi avatar KenjiTakahashi commented on July 17, 2024

Oh, ok. But it still persisted in the tutorial (in the "custom command" example) :-).

from lf.

gokcehan avatar gokcehan commented on July 17, 2024

I missed that one @KenjiTakahashi , I will take care of it.

from lf.

gokcehan avatar gokcehan commented on July 17, 2024

@KenjiTakahashi I have pushed something for unmapping with the map keyword. It feels strange at first but I like the idea of not introducing a different keyword. Plus it is consistent with the cmd removal this way. We may change it later though if it becomes too counter-intuitive. Let us see how it goes.

from lf.

KenjiTakahashi avatar KenjiTakahashi commented on July 17, 2024

Fine by me, thanks.

@gokcehan I think this can be closed, unless you want to track something more here.

from lf.

gokcehan avatar gokcehan commented on July 17, 2024

@KenjiTakahashi it is still not possible to map to a key starting with another. I personally try to avoid those kinds of bindings and I guess you too. We may track that here but with a low priority. So maybe keep the issue open in case someone gets interested in this?

from lf.

KenjiTakahashi avatar KenjiTakahashi commented on July 17, 2024

Agreed on both things :-).

from lf.

KenjiTakahashi avatar KenjiTakahashi commented on July 17, 2024

@gokcehan It seems that unmapping got broken at some point, it doesn't work on current master.

from lf.

gokcehan avatar gokcehan commented on July 17, 2024

@KenjiTakahashi Sorry, I have been trying to clean up the parser code. I have pushed a fix now. Can you get the master and try again?

from lf.

KenjiTakahashi avatar KenjiTakahashi commented on July 17, 2024

Works again, thanks!

from lf.

gokcehan avatar gokcehan commented on July 17, 2024

Now that many operations work asynchronously, a delay mechanism for keys with a common prefix needs to address what should happen when an event occurs during the delay. So implementing this in a correct manner may be quite difficult for little or no gain. I'm closing this issue as there is no current effort to implement this. Feel free to leave comments if you want to work on this or have a good idea for the implementation.

from lf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.