Giter Club home page Giter Club logo

Comments (4)

MinerYang avatar MinerYang commented on June 20, 2024 1

In fact given to the above info indicates that this signature is signer by legacy cosign version that haven't support oci-spec 1.1 yet, means can not simply collecting either media_type or manifest_media_type to do differentiation. It actual type is concealed in layers for legacy cosign behavior. It needs query two tables rather than just artifact.
However, In next harbor release it can be easily achieved by using cosign --registry-referrers-mode oci-1-1signing image

from harbor.

MinerYang avatar MinerYang commented on June 20, 2024

Which harbor and cosign version/build you are using?
Current behavior is collecting artifact.type AS artifact_type from db, we do add artifact.artifact_type column in the next release(v2.11) to collect image.Manifest.ArtifactType. So if cosign is using ArtifactType for their signature manifest (adopt oci-spec 1.1), we possibly could do so to differenciate as you expected.

from harbor.

gaglimax avatar gaglimax commented on June 20, 2024

My Harbor version is 2.10.0.
I don't know about the cosign version because my only exemple comes from a replication rule importing image and signature from a remote Harbor registry (I don't have any information about it).

Currently, in database, I have those rows :

 type  |                   media_type                   |                 manifest_media_type                  
-------+------------------------------------------------+------------------------------------------------------
 IMAGE | application/vnd.docker.container.image.v1+json | application/vnd.docker.distribution.manifest.v2+json
 IMAGE | application/vnd.oci.image.config.v1+json       | application/vnd.oci.image.manifest.v1+json

The first rows is about image artifact, the second is about the signature artifact. So if you implement a type based either on media_type or manifest_media_type, it will work indeed.

from harbor.

gaglimax avatar gaglimax commented on June 20, 2024

Ok thanks.
When Harbor 2.11 will be released, I will tell the editor to sign image with the oci-spec 1.1.
I will close the issue after the release if that's ok for you.

from harbor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.