cannot disable button programatically in brmMenu -> brmMenuGroup -> brnMenuItem about spartan HOT 8 CLOSED

I am using version 0.0.1-alpha.309, will now try to upgrade to 0.0.1-alpha.311. I noticed that the button is actually disabled, but it doesn't inherit disabled styles with opacity applied.

from spartan.

I tried now with 0.0.1-alpha.311 and issue still persists. I had some issues with peer dependencies before getting it to work with the new version, I think it's not okay to specify peer dependencies to exact version in semver like 17.0.2 but to ^17.0.0. For example I updated my app with ng update @angular/core @angular/cli and it updated it to version 17.0.4 which is not exact version as 17.0.2 which is specified in @spartan-ng/ui-menu-brain latest version;

"peerDependencies": {
  "@angular/core": "17.0.2",
  "@angular/cdk": "17.0.0"
}

but, I think it should be;

"peerDependencies": {
  "@angular/core": "^17.0.0",
  "@angular/cdk": "^17.0.0"
}

Can I open a PR for this? Otherwise other users may have issues updating to latest in the future.

Thanks, Jan

from spartan.

@jkuri I found the issue. Releasing a new version now that should have the fix!

from spartan.

What version are you using?

from spartan.

Yes. I am still trying to find a better way to manage dependencies in a better way! I am using an eslint plugin right now to sort of automate it. If you take a look at the package.json scripts that should give you an idea of what I am doing.

Let me know if that makes sense! Looking forward to the PR

from spartan.

I am using version 0.0.1-alpha.309, will now try to upgrade to 0.0.1-alpha.311. I noticed that the button is actually disabled, but it doesn't inherit disabled styles with opacity applied.

Interesting! I'll see if that's a class binding issue!

from spartan.

@jkuri 0.0.1-alpha.313 is now available on NPM with the fix. Let me know if it worked 👍

from spartan.

I updated to 0.0.1-alpha.313 and confirming that it works now 👍 thanks for the quick response and fix.

from spartan.