Description

Add the interface for collectFee().

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None

Description

Add the state change function finish() to the library.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None

Description

Implement addCommitment(), getCommitmentCount(), and participantExists() on LibCrucible.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None

Description

Add the payout() call to crucible.js.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None

Description

We need a wait to waitForTxToComplete() after sending a transaction. This is going to need to take the transaction hash and return a TransactionReceipt. This function alone will add the proper waiting after sending a transaction to allow the caller to know it's okay to proceed with other API calls.

We should also add ways to get the contents of log messages for transactions that log a message. We can do this by passing the receipt, and perhaps also building an event listener for such events. This would allow validators to edge trigger actions based on events.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None

Description

Implement the interface and tests for setGoal() and judgement().

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None

Description

When implementing addCommitment() it failed to catch the error for a risk amount that was set too low. After chasing this bug out, it would appear that ANY on-chain reject will come in out-of-band from the try/catch and interrupt the library. There are ways to catch this with web3.js, but one must use event listeners. This radically complicates the interface to LibCrucible and puts a lot onto the user of the library to implement all that error handling in event handlers. Making such a change would ruin the async/await interface and make using the library a mess.

The only option I can see is implementing an assertion framework into the API interface that is aware of every possible assertion that we could throw on-chain. The downside to this is that we have to duplicate a bunch of those assertions handled in the crucible code into the library. The upside is that web3.js has no current ability to let the contents of those assertion failures bubble up from the chain. Meaning users would be left guessing about what failed. Putting assertions in the library would fix this. What's more, a transaction that would fail on chain (so after the user signs and sends the transaction), is now likely to throw the error before any of that interface is invoked.

These two benefits clearly outweigh the concerns of duplicating assertion handling into the library.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code (complete assertion implementation)
• tests
• documentation

Example PR

#4

Bounty

None

Description

Create the interface off of the foundry that can create a new crucible. Experiment with returning a fully instantiated Crucible, but be cognizant of the delay to have this block mined and find a solution. Make sure this is implemented, well tested as a unit test and integration, and documented.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#2

Bounty

None

Description

Add a private getIndexOf() and a public deleteCrucible(). Both functions work off the foundry. There is likely no need to expose getIndexOf().

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#2

Bounty

None

Description

Add libcrucible.lock() state transition to LibCrucible.

PR must contain

• a first commit title that starts with 'CRUCIBLEJS-N:'
• code
• tests
• documentation

Example PR

#4

Bounty

None