Comments (3)
Ah yes, I'll take a look.
This actually is an existing divide by zero vulnerability in the camera code that I noticed (if I remember right), which is a pretty serious error, and could have previously resulted in crashes / corruption.
Normal procedure is usually to flag these errors and recover / fix their source, rather than hide them. So this isn't really a regression, only the reporting of the error is new.
Will give more details when I examine the MRP.
This is the code I changed:
Point2 Camera::unproject_position(const Vector3 &p_pos) const {
...
// Prevent divide by zero.
// TODO : Investigate, this was causing Nans.
ERR_FAIL_COND_V(p.d == 0, Point2());
...
p.normal /= p.d;
from godot.
I've worked out the vulnerability, full details in the PR below.
from godot.
CC @lawnjelly
from godot.
Related Issues (20)
- Issue: Path3D/PathFollow3D logic HOT 2
- RichTextLabel mouse_exited() event fires by Context Menu when control is Right Clicked HOT 1
- Image file imported incorrectly
- Is there a function to update the Project Manager? HOT 1
- PopupMenu visual issues in 3.6 RC1 HOT 1
- Using -rigid import hint on a blender model with an unapplied scale changes scale of rigidbody nodes directly, causing issues.
- Subviewport exhibiting aberrant alpha behaviour on _draw() HOT 3
- Concatenating constant arrays always gives the same array reference
- After importing a GLB file with animations using a Bone Map, some animation data seems to be lost
- Custom enumeration is not colored HOT 1
- Unused class variable warning does not have one for public class variable HOT 2
- Autocomplete does not work properly in certain circumstances.
- Animation editor breaks if snapping is set to more than 1 second
- Godot 4.3 export to Android release and debug issue aab files HOT 1
- Connect signal dialog controls not aligned
- Lightmap capture for dynamic objects don't work
- TLS Handshake error when using TLSOptions.client_unsafe
- OneShot GPUParticles keep emitting in AnimationTree HOT 1
- Broken icons in the gizmo visibility popup menu HOT 3
- setup_boot_logo: Non-existing or invalid boot splash at 'res://icon.svg'. Loading default splash. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot.