Giter Club home page Giter Club logo

Comments (6)

AeioMuch avatar AeioMuch commented on August 15, 2024 2

So far I've assumed it's Linux specific, but worth confirming by testing Windows and macOS.

This warning is happening on Windows as well.

from godot.

akien-mga avatar akien-mga commented on August 15, 2024

I've been struggling to bisect this, I bisected twice between 4.3-beta1 and master and landed on different, completely unrelated commits.

$ git bisect log
git bisect start
# status: waiting for both good and bad commits
# bad: [2fb296a5cd83bfa7a234cfcaae78a63da3556fb8] Merge pull request #93074 from bruvzg/bmp_imp_adv
git bisect bad 2fb296a5cd83bfa7a234cfcaae78a63da3556fb8
# status: waiting for good commit(s), bad commit known
# good: [a4f2ea91a1bd18f70a43ff4c1377db49b56bc3f0] Merge pull request #92571 from akien-mga/fbx2gltf-rename-path-setting-back
git bisect good a4f2ea91a1bd18f70a43ff4c1377db49b56bc3f0
# good: [ea7d988b72587c265726ccfdabd56b4083c4d2fc] Merge pull request #92781 from bruvzg/menu_open_close_imp
git bisect good ea7d988b72587c265726ccfdabd56b4083c4d2fc
# good: [4ac7a27e4333ef8a814103441fe2428ac70265e9] Merge pull request #92905 from DeeJayLSP/qoa-ups
git bisect good 4ac7a27e4333ef8a814103441fe2428ac70265e9
# bad: [41381a73fe3a5fc338416aac80f28c51ada269d6] Merge pull request #92930 from passivestar/inspector-node-delete
git bisect bad 41381a73fe3a5fc338416aac80f28c51ada269d6
# bad: [1a8c6e85ba09b0d6e13c2cb6a5e518af5662dddb] Merge pull request #93023 from akien-mga/revert-92650
git bisect bad 1a8c6e85ba09b0d6e13c2cb6a5e518af5662dddb
# bad: [4223444d87e125534c72d09c4f45ed490b0c5e5e] Merge pull request #92993 from capnm/240610-embree-error-hotfix
git bisect bad 4223444d87e125534c72d09c4f45ed490b0c5e5e
# bad: [78a96c26a9904f0b9ffb5d5f5338ca8736f87073] Merge pull request #92988 from adamscott/max-webgl-version
git bisect bad 78a96c26a9904f0b9ffb5d5f5338ca8736f87073
# good: [d3c1eb009e0002096d4f2f6c4fb5b2436da00020] Merge pull request #92908 from bruvzg/fix_main_window_initial_mouseover
git bisect good d3c1eb009e0002096d4f2f6c4fb5b2436da00020
# good: [5a01c2e954851605659d6e0104a51190bbfa4e4c] Replace deprecated `USE_WEBGL2` linker flag
git bisect good 5a01c2e954851605659d6e0104a51190bbfa4e4c
# first bad commit: [78a96c26a9904f0b9ffb5d5f5338ca8736f87073] Merge pull request #92988 from adamscott/max-webgl-version

I must have made a mistake twice... the error doesn't seem to be 100% reproducible every time.

But #92908 added an _event_callback call in Window so it's a very likely candidate, CC @bruvzg.

from godot.

akien-mga avatar akien-mga commented on August 15, 2024

Right I re-ran the last steps and confirmed that #92908 is also bad and thus this is the first bad commit:

768fd1eacba427f08b0896aa641c27846b9eb185 is the first bad commit
commit 768fd1eacba427f08b0896aa641c27846b9eb185 (HEAD)
Author: bruvzg <[email protected]>
Date:   Sat Jun 8 19:08:10 2024 +0300

    [Window] Fix mouse hover state of the main window when mouse enter event was sent before setting callbacks.

 scene/main/window.cpp | 4 ++++
 1 file changed, 4 insertions(+)

It's reproducible simply by opening the project manager and checking the console output.

So far I've assumed it's Linux specific, but worth confirming by testing Windows and macOS.

from godot.

capnm avatar capnm commented on August 15, 2024

You're right, on closer look at my older ThorVG PR backup I realize
it wasn't there...

from godot.

bruvzg avatar bruvzg commented on August 15, 2024

Probably X11 event is sent late, it should not be an issue. I'm not sure what's the best way to handle it and why this message is there in the first place. If the same window get enter event twice, it probably should be silently ignored without sending notification.

from godot.

capnm avatar capnm commented on August 15, 2024

I don't have the macOS issue that it fixes #91589 in Linux OS x11, then maybe the change should be made macOS specific.

The test was made by 2f8673d

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.