Light values incorrect when scene imported from Blender about godot HOT 10 OPEN

Had this issue when importing glTF, fixed it by exporting in compatibility (non-physical) mode from blender:

passivestar/quickmenu@a4bcad1

It's this setting in the UI:

Godot could probably do the same when exporting glTF from blend

from godot.

This seems to be the same as #73624. We are currently doing things wrong from the perspective of the spec, but the solution is not very easy since it seems that not many people actually follow spec (and the Blender exporter didn't until recently)

from godot.

This could just be the way these values are translated, the engine uses a different concept for energy that isn't a physical quantity

from godot.

I assumed as much as well. Maybe a function could be implemented to convert the values when imported.

I'm not too familiar with Godot's codebase. Will download it and see if I can write a fix on my side. Could you point me to the location of the Blender importer source code?

from godot.

Maybe a function could be implemented to convert the values when imported.

Are the resulting light values wrong, i.e. does it look wrong? Otherwise they are very clearly converted as they don't match, but aren't just random

from godot.

Their values are extremely bright for the default light values from blender. All lights in a imported scene requires adjustment.

I understand it's not best practice to use blender files, as usually it's best to export to another format. It just saves a lot of time read blender as is.

from godot.

Could you point me to the location of the Blender importer source code?

Blend files are imported by creating a GLTF document and importing that, so check the GLTF importer code for how it generates lights. See GLTFLight class.

Also see the temporary gltf file which gets generated on import into Godot (it might be in the .godot/imported folder?) to see what energy values are stored in the light in gltf.

from godot.

@RedMser Thanks, I checked the generated files for GLTF in the imported folder. Seems the GLTF conversion does store those high values. Still need to setup the environment to build the Godot source code, will look into that GLTFLight class.

from godot.

Okay I'm confused by how the values are retrieved by the import.

I looked at:

 editor_scene_importer_blend.cpp
 
 Node *EditorSceneFormatImporterBlend::import_scene(const String &p_path, uint32_t p_flags, const HashMap<StringName, Variant> &p_options, List<String> *r_missing_deps, Error *r_err)

Does it get the values from_dictionary from gltf_light.cpp file?

Also which function check what the original import format is?

from godot.

Thank you for looking into this. I'm not very familiar with Godot's code base, tried to find a solution but ended up focusing on other work.

from godot.