Giter Club home page Giter Club logo

Comments (9)

Marqin avatar Marqin commented on May 29, 2024

Why not use just simple hash (even md5 if you don't like long) for asset URL and internaly check everything by demanding developers to sign their packages with GPG?

from godot-asset-library.

akien-mga avatar akien-mga commented on May 29, 2024

Most Godot users that would like to submit assets likely don't know how to use git, so when it comes to asking them to sign their packages with GPG...

Hashing the URL is not enough as the asset can change while the URL would stay the same (e.g. if users give the URL of their GitHub repo's master zip archive). So having the sha256sum of the archive itself is necessary not only for security, but also to keep track of changing versions (e.g. if the new state of the master branch of an approved asset breaks compatibility with Godot 2.x, we'd want to make sure this is reflected in the asset's properties).

from godot-asset-library.

Marqin avatar Marqin commented on May 29, 2024

I never said to hash the URL.

from godot-asset-library.

akien-mga avatar akien-mga commented on May 29, 2024

Why not use just simple hash (even md5 if you don't like long) for asset URL

Maybe I misunderstood.

from godot-asset-library.

Marqin avatar Marqin commented on May 29, 2024

for

is not

of

...

for

Means that asset download URL is like http://example.com/assetstore/asset/d41d8cd98f00b204e9800998ecf8427e.zip

from godot-asset-library.

akien-mga avatar akien-mga commented on May 29, 2024

Sorry, I'm obviously not a native English speaker.

from godot-asset-library.

bojidar-bg avatar bojidar-bg commented on May 29, 2024

@Marqin You could have just said

simple hash (even md5 if you don't like long) [of the] asset

..And it would have been all good. But anyway, lets go on with the discusson.

from godot-asset-library.

akien-mga avatar akien-mga commented on May 29, 2024

Not blocking for beta, though would be really nice to have ;)

from godot-asset-library.

Calinou avatar Calinou commented on May 29, 2024
  • Superseded by #209.

from godot-asset-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.