Moderation: New hashes are not saved when validating update edits about godot-asset-library HOT 12 CLOSED

@akien-mga Dare to press the close button? ;)

from godot-asset-library.

Confirmed again when editing https://godotengine.org/asset-library/asset/edit/31 today.

from godot-asset-library.

@akien-mga I hope it won't be a problem if I solve this after the weekend?

from godot-asset-library.

It's ok, it's a bit tedious to have to fix the hashes in the db, but I can handle a week-end's worth of it ;)

from godot-asset-library.

Ok... that was a really stupid one 😆

from godot-asset-library.

Still valid in the currently deployed instance.

from godot-asset-library.

Ping, it's starting to be bothersome to have to always edit the database manually whenever I moderate a new version of an asset :)

from godot-asset-library.

@akien-mga I redeployed the instance, would be nice if you can give it a recheck.

Works fine locally on my end, in all scenarios.

from godot-asset-library.

Will check as soon as we have a new edit to validate.

from godot-asset-library.

There seems to be a regression which broke the feature from #19: I approved this edit without giving the hash anew, as it wasn't changing, and it validated an empty hash:

So that shows at least two bugs:

• validating an edit without giving a new hash saves an empty hash instead of keeping the existing one
• there is no validation of the given hash (could go in a new issue)

from godot-asset-library.

Strange... Will check tomorrow locally again:wink:

from godot-asset-library.

Fix confirmed \o/
I'll open another issue for the regression I mentioned above.

from godot-asset-library.