Giter Club home page Giter Club logo

Comments (9)

 avatar commented on May 30, 2024

I suggest splitting this into two separate commits - first the comments, then the commented out code. This way, it will be easy to find all commented out code, in case it is ever needed.

from collada-exporter.

 avatar commented on May 30, 2024

@set-killer I took care of #10 in #28, wanna tackle this yourself or shall I go ahead with it? (I will assume the latter if you don't reply).

from collada-exporter.

 avatar commented on May 30, 2024

I'm thinking about removing the superfluous comments (commenting one to five lines when what they do is pretty clear is not that useful), and posting the various doubts and hacks expressed by some comments on the issue tracker. I think I will go ahead and do it, please tell me if you have a problem with that.

from collada-exporter.

akien-mga avatar akien-mga commented on May 30, 2024

Fine by me.

from collada-exporter.

set-killer avatar set-killer commented on May 30, 2024

@paper-pauper I wouldn't be able to take care for this in the next few hours. If you have this opportunity please do it. Also i'm not sure if we should leave some of the comments untouched or remove them all. I guess you have better overview in this issue, so please go ahead.

from collada-exporter.

set-killer avatar set-killer commented on May 30, 2024

oh, its actually done! Nice 🎉

from collada-exporter.

 avatar commented on May 30, 2024

Only the commented out code is done, I'll do the comments myself tomorrow perhaps. Thanks for re-opening the ticket by the way, it's best to leave it open until the other part is done.

from collada-exporter.

set-killer avatar set-killer commented on May 30, 2024

w8, there is some minor thing here:
https://github.com/godotengine/collada-exporter/blob/master/io_scene_dae/__init__.py#L150

will try to fix it fast...

from collada-exporter.

set-killer avatar set-killer commented on May 30, 2024

Done.

@paper-pauper you did a great job. Noice!

from collada-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.