Giter Club home page Giter Club logo

Comments (10)

fjarrett avatar fjarrett commented on July 23, 2024 1

I handled most of this in the new Primer_Customizer class. @jonathanbardo is now working on splitting this up into logical parts so we don't have a 1000 line file.

from primer.

tobeycodes avatar tobeycodes commented on July 23, 2024

@chriswallace I have updated @fjarrett's original issue to reflect changes to make

from primer.

tobeycodes avatar tobeycodes commented on July 23, 2024

Definitely makes more sense being in a class. Originally it was just pulled out of Twenty Sixteen and was a bit of a mess

from primer.

tobeycodes avatar tobeycodes commented on July 23, 2024

I know this part was just merged from Twenty Sixteen but it makes no logical sense.

It's a callback for the custom header but changing the site-title and description

https://github.com/godaddy/wp-primer-theme/blob/issue-2-customizer/inc/customizer.php#L90-L115

from primer.

tobeycodes avatar tobeycodes commented on July 23, 2024

@jonathanbardo by the way sanitize_hex_color isn't loaded outside the customizer

https://github.com/godaddy/wp-primer-theme/blob/issue-2-customizer/inc/customizer/colors.php#L321

from primer.

fjarrett avatar fjarrett commented on July 23, 2024

@schrapel Thanks I did this, will take a look

from primer.

tobeycodes avatar tobeycodes commented on July 23, 2024

@fjarrett appreciate your work on this. Can you let me know when this stuff is in a position that we can integrate with the child themes? As of right now we are commenting out the customizer stuff since it fatals on the front end.

cc @chriswallace for ref

from primer.

fjarrett avatar fjarrett commented on July 23, 2024

@schrapel Oh really. I'm running 4.6-beta2 and there are no fatals. Looks like sanitize_hex_color is being moved outside of the Customizer https://core.trac.wordpress.org/ticket/27583. I will fix this for backwards compat now.

from primer.

tobeycodes avatar tobeycodes commented on July 23, 2024

That's a good example of something that should have been done 2 years ago when the ticket was opened haha. Thanks

from primer.

fjarrett avatar fjarrett commented on July 23, 2024

Fixed in 8712948

from primer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.