Field 'salt' doesn't have a default value about gochan HOT 3 CLOSED

generateSalt() is not used in password hashing, I believe the salt field is really a leftover from thinking about password hashing, and making sure to use salting. However bcrypt generates the salt itself.

generateSalt() is used for making the cookie for a session.

https://github.com/Eggbertx/gochan/blob/d4b7185ecd4adcd7e177c277ff4f1c7618e7e79f/src/manage.go#L476-L480

It may be the case that the salt field on staff table should be removed, since it's not used as far as I know.

from gochan.

Like @onekopaka said, the salt field is a carryover from Kusaba X's (less than great) design and has never actually been used, so I'm going to get rid of it. I'm also going to move config.RandomSeed to the DBPREFIXinfo SQL table and its value will be randomly generated when gochan is first run. If the DBPREFIXinfo table has a version row but no randomseed row, gochan will assume that something has gone catastrophically wrong, print a critical message, and exit, since this shouldn't be an issue under normal circumstances.

from gochan.

On second thought, I'm going to keep config.RandomSeed in the JSON file, but a random one will be generated on the first run if it's an empty string.

from gochan.