replacing values with a multi-line string value provides broken yaml format. about go-yaml HOT 10 OPEN

so I figured out that the library just expects you to pass in the value you require including the right indentation level.

		{
			path: "$.data.value1.orig1",
			dst: `
data:
  value1:
    orig1: orig1.1
  value2: orig2
`,
			src: `|-
      line1
      line2
`,
			expected: `
data:
  value1:
    orig1: |-
      line1
      line2
  value2: orig2
`,
		},

Passes as a test case.

from go-yaml.

#292

Also reported two years ago without any resolution. :(

from go-yaml.

I'm attempting to see if I can fix this.

from go-yaml.

Reproduced the issue in path_test.go with:

		{
			path: "$.data.value1",
			dst: `
data:
  value1: orig1
  value2: orig2
`,
			src: `
line1
line2
`,
			expected: `
data:
  value1: |-
    line1
    line2
  value2: orig2
`,
		},

I'll attempt to fix the problem.

from go-yaml.

The AST node replace doesn't care how deep it is so it plain does a replace on the node value resulting in a YAML that doesn't work.

from go-yaml.

Tomorrow I'll try to fix this. I have an idea of tracking the deepness recursively for StringNodes for multi-line text. let's see..

from go-yaml.

Nice find @Skarlso
Can something similar be done when the new value of orig1 is an object instead of a multiline string? I ask because when I stumbled on this problem I was seeing the same problem for an object.

from go-yaml.

Do you have an example?

from go-yaml.

I tried replacing objects, but the marshalling is all over the place. There is virtually no consistency in indentation whatsoever. I can't find a pattern or anything that would make it work. :(

from go-yaml.

Okay, this now worked finally:

		{
			path: "$.data.value1.orig1",
			dst: `
data:
  value1:
    orig1: orig1.1
  value2: orig2
`,
			src: `
orig1:
  newValue:
    - value1
    - value2
`,
			expected: `
data:
  value1:
    orig1:
      orig1:
        newValue:
          - value1
          - value2
  value2: orig2
`,
		},

from go-yaml.