explicit-key indicator "?" is treated as a directive about go-yaml HOT 5 CLOSED

Thank you for reporting!
This code is a bug, so I'll fix it.

from go-yaml.

@jeffalder

#151

Perhaps I could fix this issue with the above PR. Could you check it ?

from go-yaml.

Sorry it has taken me so long, I've been on holiday. I am going to work on validating this today.

You should know that I'm using https://github.com/yaml/yaml-test-suite to validate the changes. I can submit more issues based on what I find, if you'd like them. I know that the yaml-test-suite checks many corner cases which may not apply to general use cases.

from go-yaml.

Hi @goccy!

Thanks for your attention to this. I tried this branch with the YAML 1.1 example:

package main

import (
	"fmt"
	"github.com/goccy/go-yaml"
)

type Result struct {
	Sequence []string `yaml:"sequence"`
	Mapping map[string]string `yaml:"mapping"`
}

func main() {
	var result Result
	if err := yaml.Unmarshal([]byte(`
sequence:
- one
- two
mapping:
  ? sky
  : blue
  ? sea : green`), &result); err != nil {
		panic(err)
	}
	fmt.Println("good!")
	fmt.Println(result)
}

This panics:

panic: [6:5] unexpected key name
   3 | - one
   4 | - two
   5 | mapping:? sky
           ^
   7 |   : blue
   8 |   ? sea : green

This is the kind of case I would expect to be fixed in this issue. It doesn't look like #151 resolves this problem.

Note that #151 is a tiny improvement, though. v1.7.17 incorrectly renders % where #151 renders ?.

panic: [6:5] unexpected key name
   3 | - one
   4 | - two
   5 | mapping:% sky
           ^
   7 |   : blue
   8 |   % sea : green

from go-yaml.

You should know that go-yaml has some issues with this syntax as well, they're just different. go-yaml/yaml#611

from go-yaml.