Giter Club home page Giter Club logo

Comments (7)

fullykubed avatar fullykubed commented on August 19, 2024

Additional info: Does not matter whether use_global_settings is true or false.

from authentik.

BeryJu avatar BeryJu commented on August 19, 2024

From quickly looking through the code I can see how this would happen if the token expires and is rotated (when the token is rotated we currently default to the default expiry value which is 30 minutes)

from authentik.

fullykubed avatar fullykubed commented on August 19, 2024

While I could be confusing terms, I believe the issue we have found is specifically with token creation during the recovery flows.

In other words:

  1. No token / active recovery flow exists for the user
  2. Click create recovery link / send recovery email for the user
  3. Notice that the new token is created in the authentik_core_token table but that it will always have an expiration time 30 minutes in the future regardless of the token_expiry setting.
  4. Validate that after 30 minutes the reset links do not work.

from authentik.

authentik-automation avatar authentik-automation commented on August 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from authentik.

fullykubed avatar fullykubed commented on August 19, 2024

Still an issue.

from authentik.

nwinkelstraeter avatar nwinkelstraeter commented on August 19, 2024

I think the problem is that the recovery tokens are created differently from the admin interface/ via the API than they are during flow execution.

The API does not set any expiration time so it will always use the default of 30 minutes.
Maybe the API call should check for an email stage in the recovery flow and use the setting from there?
At least the recovery_email endpoint gets an email stage passed directly and could use the expiry_token value from that.

token, __ = FlowToken.objects.update_or_create(
identifier=f"{user.uid}-password-reset",
defaults={
"user": user,
"flow": flow,
"_plan": FlowToken.pickle(plan),
},

During flow execution the token is created with the token_expiry setting from the stage.

return FlowToken.objects.create(
expires=now() + valid_delta,
user=pending_user,
identifier=identifier,
flow=self.executor.flow,
_plan=FlowToken.pickle(self.executor.plan),
)

from authentik.

fullykubed avatar fullykubed commented on August 19, 2024

I experienced this via both the links generated from the admin UI and the tokens included in the email link (which I assume are a part of the flow).

Perhaps the flow component has been addressed in a recent release?

from authentik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.