<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github

Example failing test: <div class="highlight highlight-source-diff notranslate posi

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

INSERT column sorting is broken about builder HOT 5 CLOSED

go-xorm commented on May 27, 2024 1

INSERT column sorting is broken

from builder.

Comments (5)

benpaxton-hf commented on May 27, 2024

Example failing test:

diff --git a/builder_insert_test.go b/builder_insert_test.go
index 5ea8662..ef3db52 100644
--- a/builder_insert_test.go
+++ b/builder_insert_test.go
@@ -15,6 +15,10 @@ func TestBuilderInsert(t *testing.T) {
        assert.NoError(t, err)
        assert.EqualValues(t, "INSERT INTO table1 (c,d) Values (1,2)", sql)
 
+       sql, err = Insert(Eq{"e": 3}, Eq{"c": 1}, Eq{"d": 2}).Into("table1").ToBoundSQL()
+       assert.NoError(t, err)
+       assert.EqualValues(t, "INSERT INTO table1 (c,d,e) Values (1,2,3)", sql)
+
        sql, err = Insert(Eq{"c": 1, "d": Expr("SELECT b FROM t WHERE d=? LIMIT 1", 2)}).Into("table1").ToBoundSQL()
        assert.NoError(t, err)
        assert.EqualValues(t, "INSERT INTO table1 (c,d) Values (1,(SELECT b FROM t WHERE d=2 LIMIT 1))", sql)

$ go test -v -run TestBuilderInsert
=== RUN   TestBuilderInsert
--- FAIL: TestBuilderInsert (0.00s)
    builder_insert_test.go:20: 
        	Error Trace:	builder_insert_test.go:20
        	Error:      	Not equal: 
        	            	expected: "INSERT INTO table1 (c,d,e) Values (1,2,3)"
        	            	actual  : "INSERT INTO table1 (c,d,e) Values (1,3,2)"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-INSERT INTO table1 (c,d,e) Values (1,2,3)
        	            	+INSERT INTO table1 (c,d,e) Values (1,3,2)
        	Test:       	TestBuilderInsert
FAIL
exit status 1
FAIL	github.com/go-xorm/builder	0.006s

from builder.