DATA RACE in resty.(*Client).execute() about resty HOT 15 CLOSED

Thanks for reporting. I will have a look.

from resty.

@iyidan I have analyzed it, will be available in next version. If you have PR for this, feel free to send it.

from resty.

@iyidan - I have taken care of it, however will do improvements later.

from resty.

It will be part of v0.8 release, available in master branch.

from resty.

Sorry to resurrect this, just to let you know: This has broken my client as resty is not parallel anymore. I knew about the data race but it was not affecting my use case. I can fix it without much issues, but please be careful in the future about changes that change the behavior of resty so much. Thanks for the library, will keep using it! :)

from resty.

@mrd0ll4r I'm sorry about you ran into issue.

Please let me know your suggestion to improve resty. I will think about keeping parallel and prevent data race in the mean time.

Looking forward to your inputs.

from resty.

Hard to say - you could use an RWMutex for the proxy settings etc, but you allow setting a proxy for an individual Request, so that's not going to work. Maybe make it so that requests with an explicit proxy use a separate transport and HTTP client? Hard to say for sure.

You could always just say "resty is not thread safe when modifying proxy settings (and maybe more), do thread safety in your code", which works fine for me.

from resty.

@mrd0ll4r @wanghq - I thought through it. I'm planning to remove request level proxy option and mutex locking from resty.

any objections or comment?

from resty.

You'd still protect the top-level proxy with an RWMutex or something, right? Sounds good to me.

from resty.

@mrd0ll4r that's the plan, I'm gonna give it try.

from resty.

@mrd0ll4r @wanghp - mutex lock is removed from resty. I have tried RWMutex however it is not needed anymore.

I need to add note for, if resty user is modifying resty client setting from multiple goroutine/dynamically they have to use their own locking mechanism.

I have pushed changes to master. resty Performance is improved.

from resty.

@jeevatkm , thanks for the quick response! Looks good.

from resty.

@wanghq have you tested master at your end. Please let me know your feedback.

from resty.

@jeevatkm , I didn't notice any issue with the master branch. Thanks again.

from resty.

@wanghq Thank you for the confirmation.

from resty.