Giter Club home page Giter Club logo

Comments (4)

ericchiang avatar ericchiang commented on August 26, 2024

Generally I'd be open to it, but I don't have any way of testing changes. Right now I manually test PRs on MacOS and Linux machines, so it's likely that Windows support would break over time.

What do the changes look like? Is is just additional cgo configuration here?

piv-go/piv/pcsc.go

Lines 21 to 25 in e1789b3

// #cgo darwin LDFLAGS: -framework PCSC
// #cgo linux CFLAGS: -I/usr/include/PCSC
// #cgo linux LDFLAGS: -lpcsclite
// #include <PCSC/winscard.h>
// #include <PCSC/wintypes.h>

from piv-go.

tobiaskohlbau avatar tobiaskohlbau commented on August 26, 2024

Maybe it's okay to flag the windows support as experimental. We could state the fact that you're unable to test within the readme? Maybe something like Windows is community supported and not field tested by the maintainer.

I've cleaned up the changes and pushed them to https://github.com/tobiaskohlbau/piv-go/tree/feature/addWindowsSupport . I took the road without CGO as it's quiet a hurdle to setup a gcc on windows. The integration was surprisingly nice and conformant with the existing codebase. I did not run the test as I'm not aware which parts of the YK gets wiped and I'm affright of loosing my data on my YK. Best option is to go with another not critical YK... I need to order one.

Edit:

I've just checked the docs and learned that PIV is not overlapping with OpenPGP applet. I did run the tests and everything works.

Logs 
=== RUN   TestYubiKeySignECDSA
--- PASS: TestYubiKeySignECDSA (0.24s)
=== RUN   TestPINPrompt
=== RUN   TestPINPrompt/Never
=== RUN   TestPINPrompt/Once
=== RUN   TestPINPrompt/Always
--- PASS: TestPINPrompt (1.35s)
    --- PASS: TestPINPrompt/Never (0.44s)
    --- PASS: TestPINPrompt/Once (0.45s)
    --- PASS: TestPINPrompt/Always (0.46s)
=== RUN   TestSlots
=== RUN   TestSlots/Authentication
=== RUN   TestSlots/CardAuthentication
=== RUN   TestSlots/KeyManagement
=== RUN   TestSlots/Signature
--- PASS: TestSlots (3.89s)
    --- PASS: TestSlots/Authentication (0.58s)
    --- PASS: TestSlots/CardAuthentication (0.57s)
    --- PASS: TestSlots/KeyManagement (0.56s)
    --- PASS: TestSlots/Signature (0.55s)
=== RUN   TestYubiKeySignRSA
=== RUN   TestYubiKeySignRSA/rsa1024
=== RUN   TestYubiKeySignRSA/rsa2048
--- PASS: TestYubiKeySignRSA (3.97s)
    --- PASS: TestYubiKeySignRSA/rsa1024 (1.06s)
    --- PASS: TestYubiKeySignRSA/rsa2048 (2.91s)
=== RUN   TestYubiKeyDecryptRSA
=== RUN   TestYubiKeyDecryptRSA/rsa1024
=== RUN   TestYubiKeyDecryptRSA/rsa2048
--- PASS: TestYubiKeyDecryptRSA (8.02s)
    --- PASS: TestYubiKeyDecryptRSA/rsa1024 (0.87s)
    --- PASS: TestYubiKeyDecryptRSA/rsa2048 (7.15s)
=== RUN   TestYubiKeyAttestation
--- PASS: TestYubiKeyAttestation (0.31s)
=== RUN   TestYubiKeyStoreCertificate
--- PASS: TestYubiKeyStoreCertificate (0.27s)
=== RUN   TestYubiKeyGenerateKey
=== RUN   TestYubiKeyGenerateKey/ec_256
=== RUN   TestYubiKeyGenerateKey/ec_384
=== RUN   TestYubiKeyGenerateKey/rsa_1024
=== RUN   TestYubiKeyGenerateKey/rsa_2048
--- PASS: TestYubiKeyGenerateKey (5.22s)
    --- PASS: TestYubiKeyGenerateKey/ec_256 (0.14s)
    --- PASS: TestYubiKeyGenerateKey/ec_384 (0.19s)
    --- PASS: TestYubiKeyGenerateKey/rsa_1024 (0.93s)
    --- PASS: TestYubiKeyGenerateKey/rsa_2048 (3.96s)
=== RUN   TestYubiKeyPrivateKey
--- PASS: TestYubiKeyPrivateKey (0.37s)
=== RUN   TestYubiKeyPrivateKeyPINError
--- PASS: TestYubiKeyPrivateKeyPINError (0.29s)
=== RUN   TestContextClose
--- PASS: TestContextClose (0.00s)
=== RUN   TestContextListReaders
--- PASS: TestContextListReaders (0.00s)
=== RUN   TestHandle
--- PASS: TestHandle (0.00s)
=== RUN   TestTransaction
--- PASS: TestTransaction (0.00s)
=== RUN   TestErrors
--- PASS: TestErrors (0.00s)
=== RUN   TestGetVersion
--- PASS: TestGetVersion (0.01s)
=== RUN   TestCards
--- PASS: TestCards (0.00s)
=== RUN   TestNewYubiKey
--- PASS: TestNewYubiKey (0.01s)
=== RUN   TestMultipleConnections
--- PASS: TestMultipleConnections (0.01s)
=== RUN   TestYubiKeySerial
--- PASS: TestYubiKeySerial (0.02s)
=== RUN   TestYubiKeyLoginNeeded
--- PASS: TestYubiKeyLoginNeeded (0.02s)
=== RUN   TestYubiKeyPINRetries
--- PASS: TestYubiKeyPINRetries (0.01s)
=== RUN   TestYubiKeyReset
--- PASS: TestYubiKeyReset (1.61s)
=== RUN   TestYubiKeyLogin
--- PASS: TestYubiKeyLogin (0.02s)
=== RUN   TestYubiKeyAuthenticate
--- PASS: TestYubiKeyAuthenticate (0.01s)
=== RUN   TestYubiKeySetManagementKey
--- PASS: TestYubiKeySetManagementKey (0.03s)
=== RUN   TestYubiKeyUnblockPIN
--- PASS: TestYubiKeyUnblockPIN (0.05s)
=== RUN   TestYubiKeyChangePIN
--- PASS: TestYubiKeyChangePIN (0.04s)
=== RUN   TestYubiKeyChangePUK
--- PASS: TestYubiKeyChangePUK (0.04s)
=== RUN   TestChangeManagementKey
--- PASS: TestChangeManagementKey (0.03s)
=== RUN   TestMetadata
--- PASS: TestMetadata (1.60s)
=== RUN   TestMetadataUnmarshal
--- PASS: TestMetadataUnmarshal (0.00s)
=== RUN   TestMetadataMarshal
--- PASS: TestMetadataMarshal (0.00s)
=== RUN   TestMetadataUpdate
--- PASS: TestMetadataUpdate (0.00s)
=== RUN   TestMetadataAdditoinalFields
--- PASS: TestMetadataAdditoinalFields (0.00s)
PASS
ok      github.com/go-piv/piv-go/piv    27.721s

from piv-go.

ericchiang avatar ericchiang commented on August 26, 2024

🙌 yeah that patch looks clean. Awesome to see that someone else got the tests to pass too! I wonder if it'd be easy to add a CI builder to ensure it at least compiles (I can also do that separately if you like):

https://github.com/go-piv/piv-go/blob/master/.github/workflows/test.yaml

Go ahead and send a PR. Does something like this in the README sound reasonable?

Windows support is best effort due to lack of test hardware. This means the maintainers will take patches for Windows, but if you encounter a bug or the build is broken, you may be asked to fix it.

from piv-go.

tobiaskohlbau avatar tobiaskohlbau commented on August 26, 2024

I've updated the README and put in the github action workflow. I've done it from the back of my mind. Could be that something is broken but I saw that the builders for external PRs are enabled.

Earlier today I thought if it's possible to leverage a raspberry pi with an older yubikey to be a full test suite via custom github actions runner. Would be a cool weekend project to try this out.

from piv-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.