[Question or PR] Can tow engine share the same segmenter at the same time? about riot HOT 7 CLOSED

Looks like the opt.NotUseGse can't work properly while use storage.

load storage will call innerIndexDoc and send doc to segment chan.

from riot.

I will test update it, and welcome to optimization.

from riot.

All right, I'll try

from riot.

@vcaesar By the way, really pleasure to see the update of dep

from riot.

@vcaesar quite busy in past days, and our project fix the share with a temp solution, since the segmenter has a complex struct/interface and by your design I felt that you want keep the config simple.

I'm wondering using some design like what gRPC using in callOption`dialOption` to inject the complex implement like below:

// NewServer creates a gRPC server which has no service registered and has not
// started to accept requests yet.
func NewServer(opt ...ServerOption) *Server {
    //
}

What I Image the implement may look like:

type Optioner interface{
  // not designed yet
}

func (engine *Engine) Init(options types.EngineOpts, otherOpts ... Optioner ){

}

opt := types.EngineOpts{
//...
}
seg := mySeg{} // implement a `Optioner` interface
sthComplexToo := sth{} // implement a `Optioner` interface, too, may be the self imp storager
this.riotEngine = new(riot.Engine)
riotEngine.Init(opt, seg, sthComplexToo)

What's your opinion? My first target is to stripping the segmenter and second is the storager.

from riot.

Thanks for your tips and contributions, but I have a better solution, please see the code #55 .

from riot.

@vcaesar Great ~

from riot.