Giter Club home page Giter Club logo

Comments (3)

mocheryl avatar mocheryl commented on May 23, 2024 1

Maybe I wasn't clear enough. By "the Lego library doesn't account for that" I meant that the library part of the project (as opposed to the command line tool), specifically the GetRenewalInfo method, ignores the header value. This diff fixes that. It is up to whoever implements the library to decide if and how to use the newly provided value. In my case, I can use it in my custom-made service to set the next time when to rerun the renewal check process.
If I'm understood now and we agree on the issue, can I begin with a PR?

from lego.

ldez avatar ldez commented on May 23, 2024

Hello,

The only constraint for a client is to follow suggestedWindow (MUST).
The support Retry-After is recommended (SHOULD) but not required.

Your patch gets the Retry-After information but doesn't use it.

You can open a PR, you will have to add the missing elements.

Note: please use " for string, and explicit field name inside tests.

from lego.

ldez avatar ldez commented on May 23, 2024

ok, let's go for a PR.

from lego.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.