Giter Club home page Giter Club logo

Comments (5)

garrett avatar garrett commented on May 18, 2024

This is actually a bug in the default theme as well... It's just not as obvious as it is in our theme.

I may be able to fix it for Adwaita through CSS.

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

Commit eed2b01 addresses this issue somewhat. Now the pinned app tabs in tab overflow mode are not detatched from the URL bar. However, they do not have the overlapped look to them, and the backgrounds of the tabs to the right of the selected tab are still incorrect (having a gap) as a result.

At least this is a bit of progress to make it not look completely odd.

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

I worked around the overflow problem by making the min-width of tabs 16px (for the favicons to still display). This is pretty much what Chrome does in this situation.

If people really want to read the full text, there are a number of better solutions, each far superior to tab overflow mode:

  1. Switch to the tab, and the titlebar will show the title
  2. Hover over the tab to see the complete title
  3. Use Tab Groups
  4. Add List All Tabs to the tab bar

If one would add either Tab Groups or List All Tabs to the tab bar, it is recommended to add it after the +, otherwise tab overflow mode would be activated if it is in between the tabs and the +.

With this change and recommendations, I consider this as fixed as it's going to be (I think). The only other way of fixing this further is to cleverly prevent tab overflow mode in the CSS via disabling it somehow with !important.

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

I'd also like to note that tab overflow doesn't just mess up the visual appearance of themes (especially ours), but it also prevents the new tab resize behavior in Firefox 5+ on mouse-out to not work correctly. I firmly believe that tab overflow mode should be disabled in Firefox due to this and the above 4 alternatives (especially with the Firefox 4 Tab Groups view) mentioned above.

2ยข

from firefox-gnome.

pulb avatar pulb commented on May 18, 2024

This indeed looks better. Great job!

from firefox-gnome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.