Comments (5)
This is actually a bug in the default theme as well... It's just not as obvious as it is in our theme.
I may be able to fix it for Adwaita through CSS.
from firefox-gnome.
Commit eed2b01 addresses this issue somewhat. Now the pinned app tabs in tab overflow mode are not detatched from the URL bar. However, they do not have the overlapped look to them, and the backgrounds of the tabs to the right of the selected tab are still incorrect (having a gap) as a result.
At least this is a bit of progress to make it not look completely odd.
from firefox-gnome.
I worked around the overflow problem by making the min-width of tabs 16px (for the favicons to still display). This is pretty much what Chrome does in this situation.
If people really want to read the full text, there are a number of better solutions, each far superior to tab overflow mode:
- Switch to the tab, and the titlebar will show the title
- Hover over the tab to see the complete title
- Use Tab Groups
- Add List All Tabs to the tab bar
If one would add either Tab Groups or List All Tabs to the tab bar, it is recommended to add it after the +, otherwise tab overflow mode would be activated if it is in between the tabs and the +.
With this change and recommendations, I consider this as fixed as it's going to be (I think). The only other way of fixing this further is to cleverly prevent tab overflow mode in the CSS via disabling it somehow with !important.
from firefox-gnome.
I'd also like to note that tab overflow doesn't just mess up the visual appearance of themes (especially ours), but it also prevents the new tab resize behavior in Firefox 5+ on mouse-out to not work correctly. I firmly believe that tab overflow mode should be disabled in Firefox due to this and the above 4 alternatives (especially with the Firefox 4 Tab Groups view) mentioned above.
2ยข
from firefox-gnome.
This indeed looks better. Great job!
from firefox-gnome.
Related Issues (20)
- Select box arrow goes missing
- Unable to enable dark variant HOT 8
- Incompatible with Firefox 48.0 HOT 34
- GNOME Theme Tweaks menu absent in Firefox 47.0 (and perhaps other versions)
- Support for 'Personal Menu' addon
- Developer tools missing horizontal scrollbar
- Scroll bar one pixel away from edge of window HOT 2
- Compatibility with Firefox 48 HOT 2
- Favicons turn greyscale when unfocused
- "New tab" page on private windows on FF 48
- No indication that a window is private browsing
- Incorrect padding in URL input bar
- GNOME Theme Tweak is "Not compatible with multiprocess"
- Incompatible with Firefox 50 HOT 11
- Alternative now firefox-gnome is going to die (due to firefox advanced theme support removal) HOT 1
- Download dialog broken in Firefox 51
- Menu layout broken, missing options in Firefox 51 HOT 3
- Firefox 53 audio/video controls HOT 2
- Incompatiable with Firefox 57 HOT 5
- Theme obsolete - point to kurogetsusai/firefox-gnome-theme in README HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefox-gnome.