Giter Club home page Giter Club logo

Comments (8)

moul avatar moul commented on September 25, 2024 2

@harry-hov whats the current state, did you start?

I think it could be a good task for @gfanton yo complete his onboarding on the VM + CLI parts of the project.

from gno.

harry-hov avatar harry-hov commented on September 25, 2024 1

it doesn't looks too complicated at first glance, I can try to do this, but maybe @harry-hov already have something

I started working on that with my another work about publishing subdirs.
Since we are moving the _filetest.gno files to subdir(/filetests), due to this change, they will not be published to the chain. So i waited to finish work on publishing subdirs before making this change.

I followed a similar approach to what you did in your PR #1062. I cherry-picked and pushed my commit here(harry-hov@dfe2e8b) just in case if you want to take a look

from gno.

gfanton avatar gfanton commented on September 25, 2024

it doesn't looks too complicated at first glance, I can try to do this, but maybe @harry-hov already have something

from gno.

gfanton avatar gfanton commented on September 25, 2024

I've initiated a small pull request #1062. It seems to work naturally by simply adding filetest files from the filetests directory to the subpkg without any extra steps.
A few quick questions that come to mind:

  • Can the filetests folder contain _test.gno files or any other special files that is not a filetest, (like a gno.mod)?
  • Are subdirectories allowed in this folder? If so, what happens if a filetests subdirectory is present within that folder?
  • Should we support both (_filetest file and filetests directory) ?

from gno.

gfanton avatar gfanton commented on September 25, 2024

@harry-hov Is this feature truly dependent on publishing subdir? Given that filetests are not executed on-chain (yet?), can we not handle this separately?

from gno.

harry-hov avatar harry-hov commented on September 25, 2024

@harry-hov Is this feature truly dependent on publishing subdir?

Not exactly. I would just like to have that feature first.

But TBH. i have no preference. if your PR is ready we can go ahead with this change first (considering we are okay with not publishing filetests on chain)

from gno.

thehowl avatar thehowl commented on September 25, 2024

See-also: #1346 as an alternative. As a more radical approach, but I think better in the long term, I propose removing filetests for end users altogether :)

from gno.

moul avatar moul commented on September 25, 2024

I suggest doing the opposite by allowing them and adding support for txtar testing as well. Allowing this doesn't imply favoring them over standard unit tests. It aims to make it easier for users needing this feature to work outside the main monorepo. The goal is to allow creating a standalone repository with .gno files, _test.gno files, and a subfolder for advanced tests, catering to advanced users.

cc @gfanton

from gno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.