gnokey add can't add pubkeys about gno HOT 4 CLOSED

Here is the problem.

1. gno's amino marshaled pubkey byte length is 58
2. converted base256 pubkey byte length is 93
3. encoded bech32 pubkey byte length is 104

however, the github.com/btcsuite/btcutil v1.0.2 require the bech32 max length to be 90

When we add gno pubkey back to the local keybase, btcutil.bech32 tried to decode it and threw an error.
"invalid bech32 string length 104"

Solution:

1. install the latest version of btcutil
   github.com/btcsuite/btcd/btcutil v1.1.1

2. call a new method bech32.DecodeNoLimit(bech), which does not limit the pubkey bech32 length to 90.

https://github.com/btcsuite/btcd/blob/74e9690d0e402446c3c366d595123e7219f8cce7/btcutil/bech32/bech32.go#L264

I will make a pull request, if this solution is accepted.

from gno.

Trade-Off:

Since Bech32 is designed for max length 90 bytes/character with 6 checksum characters to detect and correct 4 errors with 0 faults. When we extend the length to 104, it will slightly decrease the success rate of error detection.

However, the chances of failure could be tiny. According to the BIP173 the current code selection performs well up to 1023 characters.

from gno.

that sounds great, yes please.

from gno.

Fixed by #264

from gno.