Giter Club home page Giter Club logo

Comments (13)

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

CleverRaven/Cataclysm-DDA#45146

from community-mod-compilation-deprecated.

Kenan2000 avatar Kenan2000 commented on June 2, 2024

@Theawesomeboophis The problem is in PK rebalancing, you simply need to replace S_lot in PK rebalancing with S_lot_north and it's going to work

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

Ok, and after I fix it, do I submit the fix to you, like send my files or something?

from community-mod-compilation-deprecated.

Kenan2000 avatar Kenan2000 commented on June 2, 2024

@Theawesomeboophis Make a pull request -

  1. Download GitHub Desktop ;
  2. Fork Goat's modpack and set the default location where the files should be ;
  3. Make a new random Branch having opened GoatGod's repository in GitHub desktop ;
  4. Now that you've made a new Branch, manually add your fix;
  5. Now push all the necessary commits ;
  6. Come here and press Pull Requests ;
  7. Make a new pull request ;
  8. Compare across forks ;
  9. Make sure that your new Branch name is set correctly ;
  10. Publish the PR - it should contain exactly 1 new commit of yours

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

I only found one instance of s_lot, is that correct or are there more instances that I'm not seeing?

from community-mod-compilation-deprecated.

Kenan2000 avatar Kenan2000 commented on June 2, 2024

I only found one instance of s_lot, is that correct or are there more instances that I'm not seeing?

You are right, there is only one instance in PK rebalancing that's causing this crash, all other mods are working nicely

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

Thanks, I fixed it. Trying to send fix now.

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

I sent the pull request. Hope I did it right.

from community-mod-compilation-deprecated.

Kenan2000 avatar Kenan2000 commented on June 2, 2024

Good job, amazing, thank you for your work :-)

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

Your welcome, this is my first commit, so it might not work properly.
If something breaks, please notify me and I'll fix it.

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

Did it send properly?

from community-mod-compilation-deprecated.

Kenan2000 avatar Kenan2000 commented on June 2, 2024

Yes, good job :-)

from community-mod-compilation-deprecated.

Theawesomeboophis avatar Theawesomeboophis commented on June 2, 2024

Ok, thanks.

from community-mod-compilation-deprecated.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.