Giter Club home page Giter Club logo

Comments (4)

gmallard avatar gmallard commented on June 22, 2024

Agreed that something more needs to be done when EOF is received attempt to accurately notify the caller. Thanks for the report.

I'll think about it this weekend. It might be more complex than just close(c.input) when the reader goroutine exits, especially for a 1.1 client.

Note however: reconnects, retries, fail overs, etc are totally a caller's responsibility.

from stompngo.

gmallard avatar gmallard commented on June 22, 2024

This is a very specific example of a more general problem.

Problem statement: package users are not being properly notified of network errors (including EOF) encountered during a read from the underlying net.Conn or tls.Conn.

The fix for this will address the general problem, including the specific case reported.

from stompngo.

gmallard avatar gmallard commented on June 22, 2024

Fixed: f0f8470

The read from the subscribe channel should complete with a MessageData that has a non-nil Error. In the particular case described, Error.Error() should be EOF.

Note that the package will subsequently treat this connection instance as dead, and no further operations may be performed with it.

from stompngo.

gmallard avatar gmallard commented on June 22, 2024

If you are still using the stompngo package please try the current v.1.0.2 tag.

Tag information:

b1f1d96 refs/tags/v1.0.2

Document that version number in any issue reports.

Thanks for the support.

Guy

from stompngo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.