Comments (4)
Agreed that something more needs to be done when EOF is received attempt to accurately notify the caller. Thanks for the report.
I'll think about it this weekend. It might be more complex than just close(c.input) when the reader goroutine exits, especially for a 1.1 client.
Note however: reconnects, retries, fail overs, etc are totally a caller's responsibility.
from stompngo.
This is a very specific example of a more general problem.
Problem statement: package users are not being properly notified of network errors (including EOF) encountered during a read from the underlying net.Conn or tls.Conn.
The fix for this will address the general problem, including the specific case reported.
from stompngo.
Fixed: f0f8470
The read from the subscribe channel should complete with a MessageData that has a non-nil Error. In the particular case described, Error.Error() should be EOF.
Note that the package will subsequently treat this connection instance as dead, and no further operations may be performed with it.
from stompngo.
If you are still using the stompngo package please try the current v.1.0.2 tag.
Tag information:
b1f1d96 refs/tags/v1.0.2
Document that version number in any issue reports.
Thanks for the support.
Guy
from stompngo.
Related Issues (20)
- Date race analysis HOT 4
- Potential blocking on unsubscribe with message in flight HOT 27
- Tests Fail various ways, golang at 8b22109 HOT 2
- Race in disconnect HOT 3
- Go get fetching the go1 branch HOT 9
- Support timeouts for network reads/writes HOT 16
- shutdownHeartbeats is not shutting down heartbeats HOT 16
- Abstract Connection to an interface HOT 2
- Panic: non-positive interval for NewTicker HOT 3
- readBody::utils.go panics when message body length is unexpectedly zero
- Is this a potential bug of SetWriteDeadline? HOT 3
- time.Ticker overflow HOT 1
- Potential blocking on Connection.Disconnect() HOT 2
- Use case in production environment HOT 1
- SSL Port error handling enhancement HOT 1
- golang docking ActiveMQ HOT 1
- Header Decode Shortcoming HOT 1
- Question about heartbeats HOT 2
- Disconnect hangs HOT 23
- Disconnect has incomplete error checking HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stompngo.