Comments (23)
@satya164 ping
from glucosio-android.
@bkerensa on it.
from glucosio-android.
✊
from glucosio-android.
@paolorotolo @satya164 Looks like this is our biggest final blocker for this release lets try and close this if we can by friday?
from glucosio-android.
We don't have mauch settings right now, so we can just use a basic preferences view. We can add more categories as the number of items grow.
Things we need in settings,
- Language
- Age
- Gender
- Height
- Weight
- Diabetes type
- Preferred unit
- Version
- Terms of usage
- Feedback
- Open Source Licenses
- ???
from glucosio-android.
@satya164 Yes we should also have a date and time setting so people can have locale based data and time picker versus defaulting to European. There should be a checker in Hello that checks this value on first open but also users should be able to change the setting under settings too in case something happens wrong.
from glucosio-android.
@bkerensa @satya164 do we really need Language and Date format preferences?
We can just take the value from local Android preferences. Not doing that means override a lot of code to ignore system's language...
from glucosio-android.
Fine let's detect the language from locale but can we do that with country? This also means we will have to change Hello.
And what do we do for l10n then? Like if a language is unavailable can it default to English of we don't have 100% translated?
from glucosio-android.
In HelloActivity I think we should ask for Country, not Language.
from glucosio-android.
Settings are working in latest commit. Closing.
from glucosio-android.
In the settings dialogs, the radio button which represents the current value should be checked. Currently nothing is checked.
Things which are very large, like Terms of usage, should open in a new page rather than a dialog.
The country selection should be a page, and should have search. Check System Settings > Language & input > Language
to have an idea about the design.
from glucosio-android.
@satya164 I've fixed the first bug in latest commit.
About country selection, user will not change his country a lot of times. Also because HelloView automatically selects user country based on Locale. I guess we can implement a customized view later (0.9.0 or 0.8.1).
from glucosio-android.
FYI for me its not auto selecting country it picks Afghanistan by default.
from glucosio-android.
Try to install daily again. I fixed that in latest commit.
from glucosio-android.
@paolorotolo I still think we should change it. In projects small things like this get postponed, and they are never done, coz there are always new things to do. So I would say, don't compromise on design just because it's not frequently used. Yes, it's not frequently used, but when it is, it's a real pain to use it.
from glucosio-android.
Also, there is a green button (?) in the country selection dialog.
from glucosio-android.
Also, the new terms of use page, it should be just like any other page, actionbar with back button with the title, and the content should be a scrollview with the license. The OK button doesn't have any meaning and is unnecessary.
Also, content is cut off at bottom, and no momentum scroll.
from glucosio-android.
Ok, @satya164 can you give me a .svg file of the curved line?
from glucosio-android.
I'm on mobile now. Will give you tomorrow. Or may be ask @elio if he can do a fancy arrow.
from glucosio-android.
@paolorotolo is this fixed?
from glucosio-android.
proposal settings additions.
add information about Insulin or other medications - the type, dose and time of reception
from glucosio-android.
@dmvstar This should be a separate bug we will add that to Imli our next release but it wont make this release. I'll go ahead and file that!
from glucosio-android.
Closing for now.
Please open a new issue for dedicated Languages activity and tag it as Enhancement.
from glucosio-android.
Related Issues (20)
- Make decimal input independent from the device locale HOT 2
- Use Support navigation drawer instead of third party HOT 9
- Add user height (in centimeters, or feet/inches) to initial onboarding screen (for BMI calculation) HOT 1
- Nothing happens when user allows write storage permission on the first CSV export HOT 1
- Incompatible SDK API use which may cause crash to your APP HOT 2
- Add notice about Analytics data HOT 1
- Weight entry broken after unit change HOT 1
- Wrong units when graphing body weight readings
- Replace Support in App HOT 2
- Google Drive Backup Function Crashes HOT 3
- Crash MotionEvent.java
- Upgrade Firebase Analytics to Crashalytics
- Replace Send Feedback Email to Discourse Link
- Arabic Version HOT 3
- Developer docs link HOT 1
- When using ',' as decimal separator readings are corrupted
- History list doesn't refresh when new data added
- On overview chart, low and high range lines have the wrong color when using custom range
- Spinner alignment HOT 1
- user inputs are lost on screen rotation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glucosio-android.