Giter Club home page Giter Club logo

Comments (23)

bkerensa avatar bkerensa commented on July 4, 2024

@satya164 ping

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

@bkerensa on it.

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

@paolorotolo @satya164 Looks like this is our biggest final blocker for this release lets try and close this if we can by friday?

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

We don't have mauch settings right now, so we can just use a basic preferences view. We can add more categories as the number of items grow.

Things we need in settings,

  1. Language
  2. Age
  3. Gender
  4. Height
  5. Weight
  6. Diabetes type
  7. Preferred unit
  8. Version
  9. Terms of usage
  10. Feedback
  11. Open Source Licenses
  12. ???

7-glucosio-preferences

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

@satya164 Yes we should also have a date and time setting so people can have locale based data and time picker versus defaulting to European. There should be a checker in Hello that checks this value on first open but also users should be able to change the setting under settings too in case something happens wrong.

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

@bkerensa @satya164 do we really need Language and Date format preferences?
We can just take the value from local Android preferences. Not doing that means override a lot of code to ignore system's language...

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

Fine let's detect the language from locale but can we do that with country? This also means we will have to change Hello.

And what do we do for l10n then? Like if a language is unavailable can it default to English of we don't have 100% translated?

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

In HelloActivity I think we should ask for Country, not Language.

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

Settings are working in latest commit. Closing.

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

In the settings dialogs, the radio button which represents the current value should be checked. Currently nothing is checked.

Things which are very large, like Terms of usage, should open in a new page rather than a dialog.

The country selection should be a page, and should have search. Check System Settings > Language & input > Language to have an idea about the design.

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

@satya164 I've fixed the first bug in latest commit.
About country selection, user will not change his country a lot of times. Also because HelloView automatically selects user country based on Locale. I guess we can implement a customized view later (0.9.0 or 0.8.1).

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

FYI for me its not auto selecting country it picks Afghanistan by default.

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

Try to install daily again. I fixed that in latest commit.

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

@paolorotolo I still think we should change it. In projects small things like this get postponed, and they are never done, coz there are always new things to do. So I would say, don't compromise on design just because it's not frequently used. Yes, it's not frequently used, but when it is, it's a real pain to use it.

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

Also, there is a green button (?) in the country selection dialog.

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

Also, the new terms of use page, it should be just like any other page, actionbar with back button with the title, and the content should be a scrollview with the license. The OK button doesn't have any meaning and is unnecessary.

Also, content is cut off at bottom, and no momentum scroll.

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

Ok, @satya164 can you give me a .svg file of the curved line?

from glucosio-android.

satya164 avatar satya164 commented on July 4, 2024

I'm on mobile now. Will give you tomorrow. Or may be ask @elio if he can do a fancy arrow.

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

@paolorotolo is this fixed?

from glucosio-android.

dmvstar avatar dmvstar commented on July 4, 2024

proposal settings additions.
add information about Insulin or other medications - the type, dose and time of reception

from glucosio-android.

bkerensa avatar bkerensa commented on July 4, 2024

@dmvstar This should be a separate bug we will add that to Imli our next release but it wont make this release. I'll go ahead and file that!

from glucosio-android.

paolorotolo avatar paolorotolo commented on July 4, 2024

Closing for now.
Please open a new issue for dedicated Languages activity and tag it as Enhancement.

from glucosio-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.