Giter Club home page Giter Club logo

Comments (12)

fcbond avatar fcbond commented on July 18, 2024

@ewa-rudnicka and @fcbond are still hashing out if some of the relations should be symmetric or appear in pairs. Probably only the synonym and antonym relations should be symmetric.

from gwadoc.

fcbond avatar fcbond commented on July 18, 2024

Basic documentation added by b4dbc8c

from gwadoc.

jmccrae avatar jmccrae commented on July 18, 2024

A couple of comments on the implementation of these new relationships:

  1. Could we lose the _of from property names like augmentative_of? This would fit the style better
  2. simple_aspect_pi and secondary_aspect_pi are marked as not directly applicable. So what is the point of them??
  3. ir_synonym is allowed between senses, but its parent relationship is not. This is a contradiction. I think that ir_synonym should not be allowed between senses
  4. Similarly, simple_aspect_ip and secondary_aspect_ip are allowed between synsets, but not between its parent derivation. Again this is contradictory and we should probably not allow this.

from gwadoc.

goodmami avatar goodmami commented on July 18, 2024

A couple of comments on the implementation of these new relationships:

  1. Could we lose the _of from property names like augmentative_of? This would fit the style better

I also prefer without _of, but I'm not sure we have a consistent style. Here are some existing relations with of:

  • state_ofbe_in_state
  • subeventis_subevent_of
  • manner_ofin_manner

Similarly, these by ones are inconsistent:

  • restrictsrestricted_by
  • entailsis_entailed_by

Maybe we could use some relation naming guidelines.

  1. simple_aspect_pi and secondary_aspect_pi are marked as not directly applicable. So what is the point of them??

"(not directly applicable)" is what is shown by the HTML templates when a relation is not marked as a synset-synset, sense-sense, or sense-synset relation (e.g., for constitutive). My guess is that someone forgot to mark these relations as such. Otherwise I'd agree that there's no point. I think for "constitutive", which is not defined in the DTD, it is only there to group related relations as a supertype. Maybe it should go?

  1. ir_synonym is allowed between senses, but its parent relationship is not. This is a contradiction. I think that ir_synonym should not be allowed between senses

I see the logical argument, and also I think it's easier to start with a tight schema then loosen it later than vice versa. However, in the Japanese Wordnet we have words sharing a synset where some are interregister synonyms (e.g., 召し上がる, 召しあがる, 召上る (yes, three of them), 召される, 召す, 上がる, 食事, 食む, 食らう, 食う, 食べる, 食する, and 頂く all share a synset). These cannot be modeled with a synset-only relation. But maybe adapting the schema to the data we have is putting the cart before the horse and we should instead change the data (e.g., splitting those into different synsets)?

  1. Similarly, simple_aspect_ip and secondary_aspect_ip are allowed between synsets, but not between its parent derivation. Again this is contradictory and we should probably not allow this.

Ditto my first sentence from (3) above. I don't have any opinion or counterexamples otherwise.

I have another related concern:

  1. I find the _form relations (feminine_form, masculine_form, etc.) slightly odd. Why are we talking about "form" at the synset level? That seems like a word (or sense) thing. Why not just feminine, masculine, etc.?

from gwadoc.

jmccrae avatar jmccrae commented on July 18, 2024

Yes, for 1 and 5 I also prefer shorter names.

On 3, I think that this is something that should be fixed in Japanese WordNet, Typically, register changes (e.g., 'bloke' vs 'man') are different synsets in wordnets.

from gwadoc.

fcbond avatar fcbond commented on July 18, 2024

from gwadoc.

fcbond avatar fcbond commented on July 18, 2024

from gwadoc.

fcbond avatar fcbond commented on July 18, 2024

from gwadoc.

goodmami avatar goodmami commented on July 18, 2024

Just confirming that ir_synonym is changed to synset-synset and not sense-sense as written above?

Also, I see that you've changed masculine to male and feminine to female. My qualm was with using the _form suffix, not with the masculine/feminine part. There are times that the grammatical gender does not match the natural gender (for example, from Wikipedia, cailín "girl" (Irish) is masculine), so male/female might be problematic. Which are we annotating?

from gwadoc.

fcbond avatar fcbond commented on July 18, 2024

from gwadoc.

fcbond avatar fcbond commented on July 18, 2024

from gwadoc.

jmccrae avatar jmccrae commented on July 18, 2024

Will do

from gwadoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.