Taoup runs slow about taoup HOT 6 CLOSED

Yes, it's not fast. However, it's not a problem for me. Your approach is a good one. If you would like to contribute an optimized portable shell script with this approach and create a pull request I can assign you credit in the git history.

from taoup.

Implemented. You can rm .taoup-fortune.* in your script after updating to remove old files. Automatic cache regeneration will occur regardless, you will have one more harmless cachefile per update unless explicitly cleared. I don't like implementing automatic rm ${anything} in bash, for safety.

Update also removes OSX portable random sort unless required, which should save some further execution time.

from taoup.

Added shuf.

from taoup.

@ronjouch OK here's an idea. The existing taoup-fortune script runs md5sum or md5 (as available; the latter being normal on OSX) on the taoup file. A filename is generated, .taoup.cache.<hash>. If the file does not exist, it is generated by storing the output of taoup. The file is then read as if it is the output of the program.

from taoup.

@ronjouch OK here's an idea. The existing taoup-fortune script runs md5sum or md5 (as available; the latter being normal on OSX) on the taoup file. A filename is generated, .taoup.cache.<hash>. If the file does not exist, it is generated by storing the output of taoup. The file is then read as if it is the output of the program.

@globalcitizen that would work, but I already have tooling around updating git repos (such as taoup) and post-actions, so for my current "on-the-side" solution is even better for me, as it happens only once every repo update. Here's what it looks like:

# update taoup to latest master. post-update:cache it
git-update master 'https://github.com/globalcitizen/taoup.git' /opt/taoup "./taoup | grep -v '^---' > taoup.txt"

One nit regarding your solution: one file per hash would lead to polluting the folder with tons of .taoup.cache.<hash> files. It seems more reasonable to output hash to a file (.taoup.cache), and contents to another file (taoup.md5sum). Then the script can compare md5 to cat .taoup.md5sum, and overwrite .taoup.cache if necessary.

from taoup.

@globalcitizen cool! Thanks for listening! 🙂

from taoup.