Giter Club home page Giter Club logo

Comments (9)

GladeDiviney avatar GladeDiviney commented on May 25, 2024

Yes, this is ugly. Will fix.

from gradle-android-git-version.

 avatar commented on May 25, 2024

Fixed in 0.3.4, thanks for reporting it!

from gradle-android-git-version.

hrydgard avatar hrydgard commented on May 25, 2024

Okay, so using 0.3.4 seems to work but version names got a lot longer if they include git hashes, they now seem to include the full hash? Anyway, the latest change I see in the git repo is 28 days old, how come when this fix can at most be 4 days old?

from gradle-android-git-version.

 avatar commented on May 25, 2024

Hm, the fix is in 35fb823 but it's not showing on the front page, I must not have pushed the branch :)

Commit tags should be the same as in prior versions...can you post your gradle androidGitVersion results?

from gradle-android-git-version.

hrydgard avatar hrydgard commented on May 25, 2024

gradle androidGitVersion shows a normal 1.4-20 (for example) but when I build from Jenkins using assembleRelease I get the full commit hash included, curiously. Not sure what's going on...

from gradle-android-git-version.

hrydgard avatar hrydgard commented on May 25, 2024

gradle code:

androidGitVersion {
	codeFormat = "MNPPBBBB"
	format = "%tag%%-count%%-branch%%-dirty%"
	prefix = "v"  // Only tags beginning with v are considered.
}

defaultConfig {
	applicationId 'org.ppsspp.ppsspp'
	println "Overriding Android Version Name, Code: " + androidGitVersion.name() + " " + androidGitVersion.code();
	versionName androidGitVersion.name()
	versionCode androidGitVersion.code()

Logs:

Overriding Android Version Name, Code: 1.4-20-8244b8246bcd9b7826eb56ad85942376d086b034 14000020

when doing assembleRelease, but

gradlew androidGitVersion
Overriding Android Version Name, Code: 1.4-20 14000020
Incremental java compilation is an incubating feature.
C:\dev\ppsspp\assets
:android:androidGitVersion
androidGitVersion.name  1.4-20
androidGitVersion.code  14000020

when doing gradlew androidGitVersion.

from gradle-android-git-version.

 avatar commented on May 25, 2024

Is Jenkins building from its own local branch?

from gradle-android-git-version.

hrydgard avatar hrydgard commented on May 25, 2024

Oh, sorry, yes indeed it is, the Jenkins git plugin is doing a bunch of weirdness. False alarm! Again, sorry for wasting your time.

from gradle-android-git-version.

 avatar commented on May 25, 2024

No problem!

from gradle-android-git-version.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.