Comments (5)
Hi @dgcuenca,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:
- All tasks have been assignedβοΈ
Required Changes β»οΈ
According to the project requirements:
At the time of this review, however, these are the pointings:
@paulsaenzsucre 44
@Juank628 46
@gjuliao 46
@dgcuenca 32
@belaymit 6
The general rule is that nobody can have more than 5 points than any other team member. That includes the whole team.
As you can see, @dgcuenca has 32 points, which is a lot less than @gjuliao who has 46. Also, @belaymit has just 6 points.
Therefore:
- Kindly, make sure no one in your team has more than 5 points than any other member.
That way, we will meet this particular requirement. πͺ
Tip: You could reassign tasks, move the numbers, change the values.
- This task does not have any points:
Kindly add points to it. While on it, kindly remember that no team member may have more than 5 points than any other. π
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from car_app_backend.
Thanks for your comments!
Changes were done
from car_app_backend.
note: I tried to contact the student to offer help, but got no response this time.
Hi @dgcuenca,
Great work on making the changes requested by a previous reviewer π
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes β»οΈ
- At the time of this re-review, the pointings are as follows:
paulsaenzsucre 44
Juank628 46
gjuliao 46
dgcuenca 29
belaymit 21
Again, @dgcuenca and @belaymit have very few points compared to @Juank628, @gjuliao, and @paulsaenzsucre.
The rule is that nobody can have more than 5 points than any other person on the team.
This means that @dgcuenca and @belaymit should have 41-49 points in order to meet the rule.
If I'm not being clear enough, kindly read the project requirements.
If you need extra help/clarification, kindly bug me on Slack and I'll be happy to help. π
Cheers, and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from car_app_backend.
Hello @Meltrust
Thanks for the review, changes were implemented.
from car_app_backend.
Hi @dgcuenca,
Wow, you did it π
Thank you for implementing the changes requested by the previous reviewer πͺ π₯ γοΈ
Well done!
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! π
To highlight
- Student pointing are now equal, and all tasks have points.βοΈ
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from car_app_backend.
Related Issues (20)
- (3ptx) - UML Design
- (3ptx) - Rails setup
- (3ptx) - Configure Rswag
- [3 ptx] Login / Registration
- (3ptx) - Admin Dashboard
- [ 3 ptx] My reservations
- [3 ptx] Delete a reservation
- (3pts) - Add Cancancan Authorizations
- (3pts) - Add Api Endpoints Routes
- (3ptx) - Rspec setup Rails
- (3ptx) - Pending Assignation
- [5ptx] Controller testing
- [3pts] Add Specs for Car and Reservation Models
- [3 ptx] Resolve N+1
- [ 3 pxt] End point Details Page HOT 1
- (3ptx) - Add Api Cars Endpoint
- (3ptx) - Devise Setup
- (3ptx) - MVC
- [2pts] Add Specs for User Model
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from car_app_backend.