The EnlighterJS engine turns inline elements to block elements about moodle-filter_synhi HOT 7 CLOSED

@twhitehead Thanks for the patch, please could you supply some testing instructions and data.

from moodle-filter_synhi.

No problem, and thanks for the very quick reply. If you create a moodle page in html mode (e.g., a lesson) with the following context

You can run the command <code>ls -l</code> to list all your files in long format.

and enable your plugin with the EnlighterJS engine, you should see that it renders the inline command as a block item (i.e., on its own line) like so

You can run the command
ls -l
to list all your files in long format.

instead of an inline (i.e., inside the line) like it should

You can run the command ls -l to list all your files in long format.

Reloading the page (possibly a shift+F5 will be required to avoid the browser caching the old version) after applying the patch should fix this.

from moodle-filter_synhi.

@twhitehead Sorry for the delay, just tested and accepted. Thanks for the test information. I'll just need to update the PHPUnit test. Also, I tested on M3.11, so the filter should be ok there too.

from moodle-filter_synhi.

No worries. That was plenty quick. 😁

Thanks so much for doing the testing for me.

from moodle-filter_synhi.

@twhitehead No problem, I've just credited you in the readme and I'm going to do a proper release on Moodle.org soon.

from moodle-filter_synhi.

@twhitehead FYI: https://moodle.org/plugins/filter_synhi/3.7.1.2/24260.

from moodle-filter_synhi.

Excellent. I'll see if our admin will update us now! Thanks again. 😄

from moodle-filter_synhi.