Publishing action seems to succeed when it should fail about github-actions-publish-to-github-packages HOT 5 CLOSED

@pierluigi @hectorsector

Both of these have two layers to them. First is the GitHub layer. What I mean by that is the storage allotment, or not allowing packages to share names across repositories. I can't affect those.

What I can affect is the Action itself. It looks as though it currently finishes without error is because of the Actions ToolKit. I am using the exec package to make the calls to Docker, which is doing essentially the same thing as typing them directly into the terminal. Since the command runs, the exec piece to this thinks everything is fine, since it just cares about if the command runs, not what it's individual exit code is.

It looks as though I can capture stdout with exec and parse it for Dockers exit code, and then throw an error within the Action itself to stop its execution.

What this doesn't solve

This will prevent the course from completing for the end user. We need to decide if that is the intended behavior or not. If the course fails to complete then what?

How do we fix the errors that would creep up like the ones above? How do we handle duplicate Package names within Learning Lab as a whole?

Packages have some limitation around them and how they are tied to repos and accounts. One of those is that there is no easy way to delete a Package you've created. If you want to delete a Package, you MUST use the API to do so.

Even after this Action is fixed to throw an error, how do we address the storage allotment for an account within Learning Lab?

I absolutely agree that I should handle these errors in the Action. We must also see that fixing the Action doesn't address the underlying roadblocks.

from github-actions-publish-to-github-packages.

Please see #13 for a partial fix for this. I've also mentioned a few things in that Pull Request that our team should decide on as a part of our content style guide

from github-actions-publish-to-github-packages.

@hectorsector This is quite old. I think the current plan is to refactor courses to use the official Docker action to do this task. I will not be updating the action I wrote anytime soon.

Not sure if this made the triage for swarming or not, but it'll be moot once we switch actions.

from github-actions-publish-to-github-packages.

👋 @mattdavis0351 I was adding issues to the maintenance board in bulk -- we will have to go through a triaging process before we get going.

For this one, does these issues still occur?

the Action should've reported a problem but still succeeded:

unauthorized: This operation would exceed the storage allotment for this account.

I had a package that wasn't uniquely named, so the action didn't succeed but it still reported successful:

blob upload invalid: Package "tic-tac-toe" is already associated with another repository.

If they're still happening, I would consider these to be in-scope, low-priority issues. I consider the task here either look and see if we can do anything on the course end to help with this bug, if not open an issue in the action repo and consider these closed.

from github-actions-publish-to-github-packages.

This no longer matters as we have switched to the official Docker action. All error and exception handling is now on them!

from github-actions-publish-to-github-packages.