Giter Club home page Giter Club logo

Comments (8)

eanakashima avatar eanakashima commented on May 14, 2024

👍 Having them together makes sense to me, since they're both basically friendlier translations of a UTC timestamp.

The only part that trips me up conceptually is that the update timer is always running, even if you only use the element to localize things. There's no practical issue — I just expect a thing that does localized time to run once and a thing that does relative time to run all the time. But having one line that surprises me seems better than having to work with two separate pieces for now.

from relative-time-element.

josh avatar josh commented on May 14, 2024

I just expect a thing that does localized time to run once and a thing that does relative time to run all the time

The timer should only touch from=now elements. However, I still need to make sure the timer isn't running if there are no elements on the page.

#7

from relative-time-element.

eanakashima avatar eanakashima commented on May 14, 2024

Oh, cool, didn't see #7.

from relative-time-element.

josh avatar josh commented on May 14, 2024

I just opened it!

from relative-time-element.

josh avatar josh commented on May 14, 2024

Trying to document and explain you can only use from or format is feeling weird to me. Maybe both these concerns can live in the same package but need to be separate elements.

from relative-time-element.

eanakashima avatar eanakashima commented on May 14, 2024

Maybe both these concerns can live in the same package but need to be separate elements.

Yeah, I guess having attributes that you can't use together feels a bit awkward. 👍 for two elements.

from relative-time-element.

dgraham avatar dgraham commented on May 14, 2024

One other option is to have just a single format attribute that accepts a strftime string or a keyword like now or relative.

from relative-time-element.

josh avatar josh commented on May 14, 2024

See #9.

from relative-time-element.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.