Giter Club home page Giter Club logo

Comments (17)

benbalter avatar benbalter commented on August 26, 2024

That is the intended functionality. The Gem enforces that the local Jekyll build environment more closely matches the production Jekyll environment, which is not currently on Ruby 2.0.0.

If you use Ruby 2.0.0 on your machine, something like rvm may help to allow you to build your Jekyll site within the proper environment.

from pages-gem.

metaskills avatar metaskills commented on August 26, 2024

I see what you are saying, but I really disagree with it. Putting a constraint on this gem because your production environment is not 2.0 really goes against the grain on what gems are all about. The current production constraint of github does not belong in this gem. IE, if y'all wanted to upgrade to Ruby 2.0, a small gemspec change downstream in a tiny wrapper gem is not the place to start.

from pages-gem.

sethvargo avatar sethvargo commented on August 26, 2024

I agree with @metaskills. I would much rather see a warning like:

WARN: You are using Ruby 2.0, which is not officially supported by GitHub pages. You should switch to Ruby 1.9 to most closely match GitHub's production environment.

from pages-gem.

benbalter avatar benbalter commented on August 26, 2024

@sethvargo I think that's a very sane solution that would cause the least amount of pain for users. If you just want to bootstrap a Pages setup you can, but if you want The Real Thing, you'll at least be on notice. Any idea the best way to implement that technically? Would love a pull request if you can. Reopening.

from pages-gem.

metaskills avatar metaskills commented on August 26, 2024

Seth, thanks for the great idea! Well said sir.

from pages-gem.

sethvargo avatar sethvargo commented on August 26, 2024

@benbalter I was thinking about it for a bit. We could issue a post-install message, but that would require a conditional in the gemspec. And, IIRC, that conditional is evaluated at build, not install. Give me a few to play around...

from pages-gem.

GabLeRoux avatar GabLeRoux commented on August 26, 2024

:(
capture decran 2013-08-13 a 15 09 23

Installed ruby 1.9.3 with brew and it's ok, not a big issue. For mac users, see how to install ruby on os-x with rbenv and brew

from pages-gem.

catsby avatar catsby commented on August 26, 2024

github-pages requires Ruby version ~> 1.9.3

That's a ~> not just a >. ~> is a pessimistic operator, so that error is correct.

from pages-gem.

benbalter avatar benbalter commented on August 26, 2024

Per the discussion in #11, the readme has been updated via #12 to betty clarify the project goals.

I think it's fair to leave this issue (or a pull request) open until the Gem supports Ruby 2.0.0, but, in order to ensure local builds match GitHub Pages builds, the blocker for closing the issue is going to have be the Pages server itself running Ruby 2.0.0.

//cc @parkr

from pages-gem.

parkr avatar parkr commented on August 26, 2024

@benbalter 👍

from pages-gem.

kevinSuttle avatar kevinSuttle commented on August 26, 2024

So is this technically an error or more of a warning?

from pages-gem.

kevinSuttle avatar kevinSuttle commented on August 26, 2024

Also, do you reccomend something like an .ruby-version file just to keep things in line?

from pages-gem.

robbyoconnor avatar robbyoconnor commented on August 26, 2024

+1 -- Fix this...I'm installing 1.9.3 in rvm...if using rvm this shouldn't be an issue...but allow 2.0.0 :)

from pages-gem.

benbalter avatar benbalter commented on August 26, 2024

@robbyoconnor @kevinSuttle yes, RVM or .ruby-version would be the best way to run both 1.9.3 and 2.x.x on the same machine.

from pages-gem.

kevinSuttle avatar kevinSuttle commented on August 26, 2024

@robbyoconnor Thanks!

from pages-gem.

benbalter avatar benbalter commented on August 26, 2024

The github-pages Gem should now work on, and require Ruby ~> 2.0.0, which matches the GitHub Pages build environment. Thanks for weighing in.

from pages-gem.

kevinSuttle avatar kevinSuttle commented on August 26, 2024

Woo! Thanks!

from pages-gem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.