Comments (9)
Alright. Maybe "Filter/Filter for ratio" would be an idea. I'd copy the docs explanation and add the comment for the difference in naming?
from ohsome-qgis-plugin.
In the results you will get
"ratioResult": [
{
"timestamp": "2014-01-01T00:00:00Z",
"value": 4708,
"value2": 1022,
"ratio": 0.217077
},
...
So if we only write "filter/filter for ratio" its not clear from which filter value2
is resulting from.
And the ratio is actually the result of devising filter2 by filter.
from ohsome-qgis-plugin.
Regarding
Elements Aggregation
: In the Ohsome docs this is also called "Elements Aggregation". If we should rename it, I would suggest "Feature Aggregation" to follow the QGis nomenclature.
So to explain why ohsomeAPI uses Elements and not Features: Features is what "normal" GIS people use when they work with QGIS or PostGIS or GeoJSON. This is related to the "SimpleFeature Access" Specification. Now the OSM Data Model is different and OSM calls those (nodes, ways, relations) Elements --> https://wiki.openstreetmap.org/wiki/Elements
At some point in the pipeline from OSHDB to QGIS the Elements are transformed into Features. So when we do Feature extraction we get Features, but when we do Aggregations we might aggregate things that are not features like turn restriction relations (e.g. dashboard example )
I think people must learn that OSM is different from SimpleFeatures and stick to Elements with reference to the docs
from ohsome-qgis-plugin.
New ToDos from yesterday's meeting - again not ordered by Priority, but sligthly sorted ;)
Naming/Documentation
- Input: docs should mention that polygons will be passed "as is" (
bpoly
), points will be passed with radius (bcircles
) - Time: mention UTC for Start/End Date
- Radius: Name should reflect that it's only for Point Layer Input
-
Group-By
-Options should have "cleartext" names, not/tag/groupby/boundary
or similar -
Endpoint
andParameter
options need better names -
density
-checkbox could be namedCalculate Density
or similar. - Filter/Filter2 might be clearer if they have different names
- Output layer naming could be clearer, e.g. by referencing the alg or the query or sth other. Dashboard sorta does this.
- Algorithms might be renamed, e.g. for
Elements Aggregation
to something along the lines ofAggregate Elements
(though it's not quite clear what "elements" means in this context - there probably exist better names). I'd personally assume that naming should be a description of what the algorithm does, but other algs (and algs from other plugins) could be checked for how others do it.
Parameter sorting:
- put options that influence another together:
-Radius
should go with input layer
-Group-By keys
andvalues
should go withGroup-By
- Date/Period should go in order
Start
-End
-Period
- Checkboxes for output manipulation should go together (I think that's already the case, but not sure)
- Options can be grouped and "hidden" in an "Advanced Parameters"-Tab. Can this tab be arbitrarily named? Can there be multiple? We'd probably wish for two of these option groups, one for Grouping Parameter and one for output manipulation parameters.
Others:
- Adapt plugin UI to roughly follow the Dashboard layout, albeit with input layer for bpolys.
- Implement "Provider" similar to ORS
- Query login sort of happens into the
ohsome Tools
box. One could look into whether this output could be formulated as a valid cURL-command, and whether the query can somehow be saved with the layer it corresponds to?
Optional other stuff:
- QgsProcessingParameterField has a method
dependsOnOtherParameters
- what does that do? Does it allow dynamic parameters, somehow? Similarly, QgsProcessingParameters has a methodisDynamic
- what does that do?
from ohsome-qgis-plugin.
Regarding Elements Aggregation
: In the Ohsome docs this is also called "Elements Aggregation". If we should rename it, I would suggest "Feature Aggregation" to follow the QGis nomenclature.
from ohsome-qgis-plugin.
Tagging @mcauer for input here :)
from ohsome-qgis-plugin.
Regarding: Filter/Filter2, in the docs this is also called Filter/Filter2. Maybe add an explanation in the description instead of renaming?
from ohsome-qgis-plugin.
Regarding: Filter/Filter2, in the docs this is also called Filter/Filter2. Maybe add an explanation in the description instead of renaming?
An explanation is a good idea either way.
Do you think there are good names that we could replace them by, and then maybe note in the explanation that they're called differently in the docs?
from ohsome-qgis-plugin.
fixed in #58
from ohsome-qgis-plugin.
Related Issues (20)
- Release 0.2.0-alpha HOT 1
- Replace hex with ohsome quality analyst HOT 1
- Prepare Release 0.2.1 HOT 1
- add missing changelog to metadata
- Mouse cursor not reset after interactively selecting centroids
- Accept map canvas as bbox
- Prevent config options from overflowing sceen
- Make time intervals input writable
- Improve layer naming HOT 1
- Handle GeometryCollections
- flake8
- Add support for older qgis version.
- Publish to Plugins repository
- Go-Live Strategy HOT 1
- UI Improvements HOT 11
- Switch to QgsNetworkAccessManager
- Query project crs every time the centroid tool is used
- Mouse cursor always on HOT 2
- Add coordinates to 'Geometry shortened' message
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ohsome-qgis-plugin.