Giter Club home page Giter Club logo

Comments (6)

giordano avatar giordano commented on June 11, 2024

Mostly addressed by f1e687f, 4f90098, and fe8a413. The main remaining issue I see is that now collect(::StarWarsArray) fails (it didn't use to up to 8e41eef)

from starwarsarrays.jl.

mkitti avatar mkitti commented on June 11, 2024

axes is supposed to return

a tuple of AbstractUnitRange{<:Integer} of valid indices

from starwarsarrays.jl.

giordano avatar giordano commented on June 11, 2024

How do you think you can do a AbstractUnitRange{<:Integer} for this indexing?

from starwarsarrays.jl.

mkitti avatar mkitti commented on June 11, 2024

I'm just quoting @mbauman here

https://discourse.julialang.org/t/offsetarrays-inbounds-and-confusion/81295/50

from starwarsarrays.jl.

mkitti avatar mkitti commented on June 11, 2024

I suppose that axes only has to return valid indices. They do not have to be in iteration order.

from starwarsarrays.jl.

jariji avatar jariji commented on June 11, 2024

They do not have to be in iteration order.

Can't we just add that requirement to the AbstractArray docs? It seems like a complication and I'm not seeing much advantage.

from starwarsarrays.jl.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.