Dill integration about hissp HOT 1 CLOSED

The simplest approach would be to factor out the pickle into a constant. That would allow monkeypatching to work on the hissp package alone without rewriting the whole method. You still have to patch two places though.

The most correct might be to factor it out into a ContextVar, which might be the closest thing the Python standard library has to dynamic vars. It's arguably not a monkeypatch at that point. But do we really need that? Would we ever want to use dill and pickle in the same session? Maybe, Hissp is not necessarily run where it is compiled. I don't think this buys us much over a constant though. If you need that degree of control, unittest.mock.patch can swap the context for you as long as you're not threading or doing async shenanigans.

The above is arguably still a monkeypatch because it still needs the pickle global to be replaced. Ideally, that would read from the same ContextVar instead, but that would be a bit awkward in any place the compiler is using pickle, which brings us to the third option: infer the import name pickle from the .__name__ attr of the pickle module. This arguably fixes a DRY violation, where the same bit of information is stored in another place, although one too minor to normally bother with considering its greater overhead. However, this would make the first attach line all you need to monkeypatch to enable dill. Let's go with that for now.

from hissp.