Giter Club home page Giter Club logo

Comments (12)

oelerpearler avatar oelerpearler commented on June 24, 2024 3

Hi @anthonyorona ! I have actually not that big of an idea how the typescript watcher works under the hood, but I had the same issue that my changes on the typescript files on a Windows Host didn't trigger any tsc-watch rebuilds inside my docker container based on the node image (weird thing though, is that it worked for me approximately a year ago, so no Idea what changed in the meantime, be it docker bind mounts, tsc --watch or tsc-watch). Probably similar to you, file changes were correctly mirrored into the docker container, but the typescript watcher just didn't get triggered.

However, even though it is probably a less CPU friendly way, things worked for me as soon as I've explicitly set the watchOptions' watchFile & watchDirectory tsconfig settings to one of the "polling" settings likes fixedpollinginterval, prioritypollinginterval etc. (https://www.typescriptlang.org/tsconfig#watch-watchFile). So e.g. following in the tsconfig file worked then:

{
  ...
  "watchOptions": {
    "watchFile": "dynamicprioritypolling",
    "watchDirectory": "dynamicprioritypolling",
    "excludeDirectories": ["**/node_modules", "dist"],
  }
}

from tsc-watch.

YouneLL avatar YouneLL commented on June 24, 2024 3

the problem persists, this issue needs to be reopened, it seems like tsc-watch is not working properly with docker's container anymore

from tsc-watch.

gilamran avatar gilamran commented on June 24, 2024

To narrow down the problem, can you just run it with tsc --watch without any hot reload. does it work?

from tsc-watch.

gilamran avatar gilamran commented on June 24, 2024

@anthonyorona Can you confirm @oelerpearler's solution?

from tsc-watch.

gilamran avatar gilamran commented on June 24, 2024

Bump before closing

from tsc-watch.

gilamran avatar gilamran commented on June 24, 2024

@YouneLL @anthonyorona Can any of you provide an example of the failure?

from tsc-watch.

piotr-cz avatar piotr-cz commented on June 24, 2024

There is no failure, tsc-watch simply doesn't restart after files have changed.

from tsc-watch.

gilamran avatar gilamran commented on June 24, 2024

Can someone please provide an example?

from tsc-watch.

piotr-cz avatar piotr-cz commented on June 24, 2024

This is my workaround:

tsconfig.json

{
  // ...
  "watchOptions": {
    "excludeDirectories": ["**/node_modules", "dist"]
  },
}

Dockerfile

# ...
CMD npm run dev -- --watchFile dynamicPriorityPolling --watchDirectory dynamicPriorityPolling

I wasn't able to use Dockers exec form, it somehow messes up arguments

from tsc-watch.

piotr-cz avatar piotr-cz commented on June 24, 2024

@gilamran
I'd say that this may be reproduced for any project using tsc-watch on Docker.

Maybe synced changes don't trigger native file events within container that typescript relies on by default.

This may be also Windows host - only issue as I'm on Windows 10

Related issue: microsoft/TypeScript#54144

from tsc-watch.

gilamran avatar gilamran commented on June 24, 2024

yea, ok so the reason is probably what @piotr-cz mentioned: microsoft/TypeScript#54144
tsc-watch is relaying on tsc to do the actual watch. If it's not working for typescript it work for tsc-watch

from tsc-watch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.