Giter Club home page Giter Club logo

Comments (9)

flammie avatar flammie commented on August 26, 2024

I wonder if the error in awk was only added because forrest did not like empty files and can be removed too?

But in any case grepping etc. is good... another thing on todo list is that the generated doccomments -> markdown files should go back to gitignore probabl, we don't need commits of them any more.

from giella-core.

snomos avatar snomos commented on August 26, 2024

I think you are right about the error and Forrest.

And I agree wrt gitignore, but I was thinking that we should wait with adding them to gitignore until all languages are converted. Now that. I spell it out, I see that that thought does not hold - it is better to add to gitignore right away. Will do.

from giella-core.

snomos avatar snomos commented on August 26, 2024

This grep command gives a reasonable list:

grep -rl --exclude 'Makefile*' --exclude '*.pmscript' --exclude '*.xfscript' '!! ' ../src/* ../tools/*

At some point we should probably also add support for xfscripts, regexes and pmscripts. But for now this should be a good start.

from giella-core.

flammie avatar flammie commented on August 26, 2024

3f9a840 should do it but it also has potential to break things

from giella-core.

Trondtr avatar Trondtr commented on August 26, 2024

I seem to have been trapped in the middle, I get (here for sje, but for all lgs):

Making all in docs
make[2]: *** No rule to make target adverbs.lexc-stems.md'. Stop. make[2]: *** No rule to make target conjunctions.lexc-stems.md'. Stop.
...
make[2]: *** No rule to make target adpositions.lexc-stems.md'. Stop. make[2]: root-morphology.md' is up to date.

So what to do??

from giella-core.

flammie avatar flammie commented on August 26, 2024

the github action works now so I think it might be a problem in the mac sed here:

		x=`basename $$f | sed -e 's/\.\(lexc\|twolc\|cg3\)$$//'` ; \

on linux it works like so:

basename src/fst/stems/adverbs.lexc | sed -e 's/\.\(lexc\|twolc\|cg3\)$//'
adverbs

it seems that fails here.

from giella-core.

Trondtr avatar Trondtr commented on August 26, 2024

gsed pro sed?
And yes, both the generated .md and the generate-markdown... files sould be ignored, already now, as a matter of fact.

from giella-core.

flammie avatar flammie commented on August 26, 2024

Ah yes, we need to include it in the configure checks then, I'll write that in the next template too, can you try if configure works in template-lang-und on Mac before merger?

from giella-core.

flammie avatar flammie commented on August 26, 2024

The gsed is now part of the checks in all langs but also the filename handling is solely based on abusing basename and dirname... the makefile rules will receive similar handling eventually.

from giella-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.