Turkish character issue about caption HOT 10 OPEN

Unfortunately, this bug hasn't been fixed (yet). We tried passing the encoding to caption-core but Node supports only a few encodings. We need to find a different way to handle unknown encodings.

List of supported encodings: https://stackoverflow.com/questions/14551608/list-of-encodings-that-node-js-supports

from caption.

i think problem caption-core iconv convert subtitle files..

from caption.

Thanks @burakereno, can you give me an example of your search query? What show did you search for when you encountered this problem?

It could indeed be an issue with caption-core. we need to add some tests there to check how we're handling character encoding.

from caption.

thanks @vernondegoede , I tried Shameless and Dunkirk. The same problem was appear but when ı manually downloaded on the website, Turkish character problem was disappear. The old version was work fine.

from caption.

@burakereno we're working on a fix that will be released in a couple of days. To test it properly can you please send me the specific subtitle file downloaded manually from the source website?

Thanks.

from caption.

@gielcobben first of all thanks for be interested. I downloaded subtitles for Dunkirk and Shameless last season from this site http://www.turkcealtyazi.org/sub/693454/shameless.html
Work fine.

from caption.

did you fix this bug?

from caption.

if you do the encoding as utf8, the problem will be fixed.

from caption.

Guys, please fix this issue. I use Caption every day :)

from caption.

Hi. i still see this issue is not fixed. Am i right? I use it for Greek subs

from caption.